Repository navigation
fix: replace removed pagy_bootstrap_nav helper in invitation logs index - #3039
Merged
Merged
Conversation
pagy 43 removed the legacy pagy_* helpers, so the view raised NoMethodError as soon as an invitation log spanned more than one page. Call series_nav(:bootstrap), the same helper the shared pagination partial uses, and cover the multi-page render with a controller spec.
mroderick
marked this pull request as ready for review
October 15, 2026 11:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invitation logs index raised
NoMethodErrorwhenever an invitation log spanned more than one page: pagy 43 removed the legacypagy_*helpers the view still called. The view now callsseries_nav(:bootstrap), the same helper the shared pagination partial uses, so multi-page logs render a nav again.Closes #3038
Review notes
app/views/admin/workshop_invitation_logs/index.html.haml; the spec defines the expected behaviour (multi-page render).shared/_pagination. This view has been broken since the pagy 43 upgrade, so there is no working before-state to compare against.Detail
pagy_bootstrap_navwas a pagy ≤ 5 helper; pagy 43 providesseries_nav(style)instead, and nothing in the app defines the old name.render_views(controller specs skip view rendering otherwise), seeds 21 logs to cross the 20-per-page boundary, and asserts the bootstrap nav markup. The logs usestatus: 'completed'becauseindex_invitation_logs_unique_activeonly allows one running log per loggable/audience/action combination.