Replace the fake upload preset in the upload_widget template - #126
Merged
Merged
Conversation
`cld make upload_widget` wrote `upload_preset: 'preset1'`. Accounts do not have this preset, so the widget failed and nothing told the user why. Use a clear placeholder and a comment that says to create an unsigned upload preset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cld make upload_widgetputs the user's cloud name into the code, but it wroteupload_preset: 'preset1'. Accounts do not have this preset, so the widget fails. The output looks complete, so the user does not know that they must change it.Brief Summary of Changes
cloudinary_cli/templates/html/upload_widget: replace'preset1'with'<your_unsigned_upload_preset>'and add a comment that says to create an unsigned upload preset in the Cloudinary Console.test_cli_make_upload_widgetchecks for the placeholder.What does this PR address?
Are tests included?
Reviewer, please note:
Checklist:
Local test run: I ran the full suite on Python 3.8 with Click 8.1.8. The new tests pass, and they fail without the fix. 8 tests in
test_cli_agent.pyandtest_cli_config_oauth.pyfail withstderr not separately capturedon this branch and onmastertoo. These tests need Click 8.2, which needs Python 3.10 or later. CI must confirm the full result.🤖 Generated with Claude Code