Repository navigation
knowledge: insert unauthored text with a String.replace replacer function ($$, $& are templates) - #282
Open
choiyounggi wants to merge 1 commit into
Open
knowledge: insert unauthored text with a String.replace replacer function ($$, $& are templates)#282choiyounggi wants to merge 1 commit into
choiyounggi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knowledge flush — 1 insight(s)
Headless autoflush run. 16 queue rows were claimed. 4 were found and judged: 1 ingested, 3 released as pending duplicates of open PRs. The other 12 were released untouched, because this run could not find them (see the Open-PR check).
Verified best-practice
Candidate
85e196ab8171f1d5— when a JS/TS script inserts text it did not write withString.prototype.replace, pass that text through a replacer function.fromis a plain string.$$becomes$.$&,$`and$'insert the match, the text before it and the text after it.$nand$<name>insert capture groups (regex patterns only). The value a replacer function returns is inserted as-is.replaceAlland regex replacements follow the same rules."abc".replace("c", "$&")with a function replacement must keep the literal$&.replace().replaceandRegExp.prototype[Symbol.replace]. A WebKit changeset in the search results cites it.AS $$ … $$fixture was spliced in withstr.replace(from, to). Postgres then failed with 42601syntax error at or near "$". Redoing the splice so the text went in verbatim made the suite pass 6/6.Existing-layer check
wiki_searchwas run with the candidate's trigger and with a paraphrase (k=8 each). Top hits:^/$anchors in allowlist tests. Different trigger.related:link both ways.replacereplacement patterns, so this is a new page. No conflicts were flagged.wiki/backend/node/index.mdhad nolanguagecategory.wiki/backend/python/index.mddoes have one, and it served as the model.Pages read: infrastructure-config-config-values-emitted-as-source-text, platforms-shells-escapes-in-shell-string-literals, testing-quality-anchor-cases-for-allowlist-regexes, infrastructure-agent-orchestration-worktree-isolated-workers
Open-PR check
Open
knowledge/*heads: #280, #279, #275, #274, #273, #272, #271, #270, #269, #268, #266, #265. This run cannot git-diff them, so overlap was judged from each PR's title and file list (gh pr list … --json number,title,files).85e196ab8171f1d5JSString.replace$patternsbackend/node/language/or a JS string-replacement topic.12aa086463fd4e2amacOS BSD grep:$in a BRE with|alternation is literalplatforms/tools/bsd-vs-gnu-cli.md,platforms/shells/portable-shell-scripts.md) and #265 (wrapped grep)66f97671dfa1b324Prisma 7 driver adapter: COMMIT-time errors arrive asDriverAdapterErrorand slip past aninstanceof Prisma.*Errorwrapperbackend/common/orm/prisma-7-…)447c9601617b87caAssertion-count detector misses unittestself.assert*testing/quality/checks-that-cannot-pass.md,harness-reverse-controls.md)The 12 other claimed ids could not be located:
~/.dev-loop/queue/, and the session files holding these rows could not be found from session ids./dev-loop:knowledge-flushwill process them.Routing decision
85e196ab8171f1d5→backend/node/language/string-replace-replacement-patterns.md, idbackend-node-language-string-replace-replacement-patterns.domain: testinghint was not followed. The lesson is a JavaScript language rule that applies to any script splicing text, not a test-design rule.languageto thebackend/nodesubtree. Why: the node subtree only hasruntime(process/runtime environment),asyncandboundaries(validating external data). None of them covers built-in language semantics. The python subtree already keeps its equivalent traps underlanguage/.wiki/backend/node/index.mdgets a new## languagesection at the end of the file. It goes at the end so it does not sit next to rows that open PRs knowledge: dead first nameserver, plugin deps after update, split-task DoD, request-body reader cancel #266 and knowledge: claude --json-schema draft-7, scraped-text noise cut, fs-mock default export, count restatements #268 add to that index.log.mdgets an ingest line.related:link added both ways with infrastructure-config-config-values-emitted-as-source-text.INDEX.mdandwiki/backend/index.mdwere left unchanged. Their node rows already send any Node.js/TypeScript code question to the node subtree. Open PRs knowledge: wrapped grep, review diff base, frontmatter quotes, GITHUB_TOKEN chaining, blind LLM judges (+4 amends) #265/knowledge: no-html-link-for-pages misses static App Router routes, tsx top-level await without type:module, Server Action refresh() of the current route #274/knowledge: blur-driven layout shift that swallows the next click, fixtures whose id/position/order coincide #279 (INDEX.md) and knowledge: wrapped grep, review diff base, frontmatter quotes, GITHUB_TOKEN chaining, blind LLM judges (+4 amends) #265/knowledge: dead first nameserver, plugin deps after update, split-task DoD, request-body reader cancel #266/knowledge: claude --json-schema draft-7, scraped-text noise cut, fs-mock default export, count restatements #268/knowledge: stream pull probe, pooled lock control, jsdom select survivor, Korean bigram dedupe, clipboard copy, Next.js request-time reads, photo downscale #269/knowledge: refusing a subcommand when the selected backend lacks the capability it needs (scheme-only stderr line, usage-class exit code decided on entry) #272 (backend/index.md) edit those files.Local-layer candidates
none