Add settings preference client - #121
cb-hareeshv wants to merge 1 commit into
Conversation
Expose list and upsert for /preferences, plus preference definitions, including the billing_rules setting group. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (13)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe SDK adds preference and preference-definition models, parameter and response types, service operations, and client accessors. Preference operations support listing and upserting; preference definitions support listing. Both services expose synchronous and asynchronous request methods. ChangesPreference API
Preference-definition API
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant ClientMethods
participant ServiceRegistry
participant PreferenceService
participant PreferencesAPI
ClientMethods->>ServiceRegistry: preferences()
ServiceRegistry->>PreferenceService: create or return service
PreferenceService->>PreferencesAPI: GET /preferences
PreferencesAPI->>PreferenceService: JSON response
PreferenceService->>PreferenceService: parse PreferenceListResponse
sequenceDiagram
participant ClientMethods
participant ServiceRegistry
participant PreferenceDefinitionService
participant DefinitionsAPI
ClientMethods->>ServiceRegistry: preferenceDefinitions()
ServiceRegistry->>PreferenceDefinitionService: create or return service
PreferenceDefinitionService->>DefinitionsAPI: GET /preferences/definitions
DefinitionsAPI->>PreferenceDefinitionService: JSON response
PreferenceDefinitionService->>PreferenceDefinitionService: parse PreferenceDefinitionListDefinitionsResponse
Merge Risk: ⚪ Minimal · up to The new preference operations have no confirmed merge-blocking issue. Normal checks remain appropriate before merging. 🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
|
Summary
GET/POST /preferencesandGET /preferences/definitions).billing_rulessetting group fromfeat/SSM-1125.Test plan
client.preferences().list(...)callsGET /preferenceswithsetting_group[is]=billing_rulesclient.preferences().upsert(...)callsPOST /preferencesclient.preferenceDefinitions().listDefinitions(...)callsGET /preferences/definitionsemailLogs()client methods are still presentMade with Cursor
Adds Java v4 client support for
GETandPOST /preferencesandGET /preferences/definitions, with sync and async methods. Adds preference and definition models, request parameters, response types, and client accessors. Includes theBILLING_RULESsetting group.