Skip unused attribute pattern lookups when constructing an ExecutionFrame. - #2300
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_989798941
branch
from
September 29, 2026 00:43
278b881 to
f32338b
Compare
copybara-service
Bot
changed the title
…rame. `ExecutionFrameBase` only calls `activation.GetUnknownAttributes()` / `GetMissingAttributes()` when unknown processing / missing attribute errors are enabled; otherwise it passes empty spans to `AttributeUtility`, which never consults them in that configuration. Note: the effect on the upstream suite is small (time/op geomean -0.5%, INSTRUCTIONS/op -0.5%); the policy benchmarks improve 4-6% while other benchmarks move within +/-4%. PiperOrigin-RevId: 989798941
copybara-service
Bot
force-pushed
the
test_989798941
branch
from
September 29, 2026 01:22
f32338b to
843d9d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip unused attribute pattern lookups when constructing an ExecutionFrame.
ExecutionFrameBaseonly callsactivation.GetUnknownAttributes()/GetMissingAttributes()when unknown processing / missing attribute errorsare enabled; otherwise it passes empty spans to
AttributeUtility, whichnever consults them in that configuration.
Note: the effect on the upstream suite is small (time/op geomean -0.5%,
INSTRUCTIONS/op -0.5%); the policy benchmarks improve 4-6% while other
benchmarks move within +/-4%.