Reuse CelExpressionFlatImpl evaluation state across non-concurrent Evaluate calls. - #2299
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…aluate calls. - `CelExpressionFlatImpl` now owns a `FlatExpressionEvaluatorState` (`cached_state_`) that `Evaluate(activation, arena)` reuses when it is not already in use (claimed via `std::atomic<bool> cached_state_in_use_`). Concurrent callers fall back to the existing per-call `InitializeState` path, so thread safety is unchanged. - This avoids allocating/freeing the evaluator state (value stack, comprehension slots, iterator stack) on every evaluation. - `FlatExpressionEvaluatorState` gains a `dirty_` flag so `Reset()` is a no-op when nothing was evaluated, plus `SetArena()` so the cached state can be bound to the caller's arena for the duration of one call. - Removes the redundant `state->state().Reset()` in `Trace`. PiperOrigin-RevId: 988498326
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse CelExpressionFlatImpl evaluation state across non-concurrent Evaluate calls.
CelExpressionFlatImplnow owns aFlatExpressionEvaluatorState(
cached_state_) thatEvaluate(activation, arena)reuses when it is notalready in use (claimed via
std::atomic<bool> cached_state_in_use_).Concurrent callers fall back to the existing per-call
InitializeStatepath, so thread safety is unchanged.
comprehension slots, iterator stack) on every evaluation.
FlatExpressionEvaluatorStategains adirty_flag soReset()is a no-opwhen nothing was evaluated, plus
SetArena()so the cached state can bebound to the caller's arena for the duration of one call.
state->state().Reset()inTrace.