Repository navigation
Update incident components when recording an update - #481
Open
devmitulpatel wants to merge 2 commits into
Open
devmitulpatel wants to merge 2 commits into
devmitulpatel wants to merge 2 commits into
Conversation
Incident updates can now carry an optional list of impacted components and the status to move them to. The CreateUpdate action syncs those statuses without detaching components the update does not mention, and attaches components that are not impacted yet.
The Record update modal now preloads the incident's impacted components with their current status, so operators can move them on as part of the update message.
Author
|
Screenshot of the Record update modal with the new Components section preloaded from the incident's current impact:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194.
Changes
CreateIncidentUpdateRequestDataaccepts an optionalcomponentsarray (component id and status), so the API can move component statuses when recording an update.CreateUpdateaction syncs the incident'sincident_componentsstatuses: existing impacts are updated, components that are not impacted yet are attached, and components the update does not mention are left alone.Verification
vendor/bin/pest— 1151 passedvendor/bin/pint --test— cleanvendor/bin/phpstan analyse— no errors