Repository navigation
Allow saving a stored banner image in Manage Theme - #480
Open
VincentBorgers wants to merge 1 commit into
Open
VincentBorgers wants to merge 1 commit into
VincentBorgers wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The banner image field contains a file path that is not permitted.This also blocks replacing or removing the banner (Banner image upload fails with "The banner image field contains a file path that is not permitted"聽#467, Site banner change bug聽#471).app_bannerFileUpload usespreventFilePathTampering(). On a settings page the existing stored path is not registered as an allowed path, so the guard rejects it on every save, even when nothing changed.allowFilePathUsingto permit a path when the file actually exists on the configured uploads disk. Tampered or non-existent paths are still rejected; a stored banner is accepted again. The closure uses the same disk the field already uploads to.Validation
mainwith the error above and passes with the fix.vendor/bin/pest: 1145 passed (4237 assertions), aftercomposer build.vendor/bin/pint --test: passed.vendor/bin/phpstan analyse src/Filament/Pages/Settings/ManageTheme.php: no errors.Fixes #467
Fixes #471