Repository navigation
Fixed issue in VI with SOR - #12
Merged
Merged
Conversation
areenberg
added a commit
that referenced
this pull request
Oct 9, 2026
Patch bump: fixes incorrect VI+SOR values/policy on general MDP models (ModifiedPolicyIteration::valueIterationSORGenMDP used the policy's stored action for the reward term instead of the candidate action being evaluated - issue #11). No API changes. Verified via PR #12's full build+test matrix across Linux, Windows, and macOS. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue in method
valueIterationSORGenMDPwhich led to a wrong value calculation and correspondingly wrong policy.