Skip to content

warn when the setup scripts use the default secret keys - #14385

Open
Damans227 wants to merge 1 commit into
apache:4.22from
Damans227:warn-placeholder-secret-keys
Open

Damans227 wants to merge 1 commit into
apache:4.22from
Damans227:warn-placeholder-secret-keys

Conversation

@Damans227

Copy link
Copy Markdown
Collaborator

The two setup scripts that set the secret keys for db.properties fall back to the word "password" when no key is given, and their help shows that as a normal choice. So many setups end up with keys anyone can guess. This prints a note when an easy to guess key is used, and the help now says to pass a random key on a new setup and keep the old key on an existing one. Nothing else changes.

Original change by @mprokopchuk.

Test:

Ran both scripts with the default keys, then with random keys.

Before: no note with the default keys.

After: a note with the default keys, none with random keys.

@codecov

codecov Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.01%. Comparing base (0931cf8) to head (78095c6).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #14385      +/-   ##
============================================
- Coverage     18.02%   18.01%   -0.01%     
+ Complexity    16248    16244       -4     
============================================
  Files          5936     5936              
  Lines        535866   535866              
  Branches      65614    65614              
============================================
- Hits          96574    96524      -50     
- Misses       428291   428352      +61     
+ Partials      11001    10990      -11     
Flag Coverage Δ
uitests 4.04% <ø> (ø)
unittests 19.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants