Add map argument autocomplete - #229
Open
dheeraj12347 wants to merge 1 commit into
Open
dheeraj12347 wants to merge 1 commit into
dheeraj12347 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @Pearl1594 and @DaanHoogland , I’ve raised the map argument autocomplete work as a separate PR: #229. It adds autocomplete support for
Whenever you’re available, could you please have a look and let me know if the approach looks good or if anything should be changed? PR: #229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add autocomplete support for
mapAPI arguments in CloudMonkey.Changes
tags[0].key=tags[0].value=mapargument follows the key/value structure.Testing
gofmt -w cli/completer_test.gogo test ./...git diff --checkAll tests are passing.