Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks! I gonna take a look. |
|
@jbonofre can you also take a look at this one? |
|
@kou since you took a look at my last 2 CI changes, can you also take a look at this one? |
| path: java-build.tgz | ||
| retention-days: 1 | ||
| - name: Exclude reactor artifacts from Maven dependency cache | ||
| run: rm -rf .docker/maven-cache/repository/org/apache/arrow |
There was a problem hiding this comment.
Why do we need to remove them? We can't use them to avoid rebuilding Arrow Java, right?
There was a problem hiding this comment.
It is removed so the cache doesn’t carry old Arrow binaries into future runs. The binaries are already in the build artifacts used by every test job
| - arch: AArch64 | ||
| jdk: 17 | ||
| macos: latest |
There was a problem hiding this comment.
It seems that we need os: macos-XXX here.
There was a problem hiding this comment.
not sure I understood. Isn't that what was done here?
| - name: Cache Docker Volumes | ||
| if: ${{ matrix.compose_service }} | ||
| uses: actions/cache@v6 | ||
| with: | ||
| path: .docker/maven-cache | ||
| key: java-build-${{ env.BUILD_JDK }}-${{ env.MAVEN }}-${{ hashFiles('compose.yaml', '**/pom.xml') }} | ||
| restore-keys: java-build-${{ env.BUILD_JDK }}-${{ env.MAVEN }}- |
There was a problem hiding this comment.
Why doe we need this?
download-artifact isn't enough?
There was a problem hiding this comment.
this avoids downloading external dependencies again in each job. download-artifacts only contains the compiled Arrow output and installed org/apache/arrow artifacts
18a8b8a to
5309167
Compare
3 participants
What's Changed
memory-corecustom test executions.Closes #1283.
This PR was assisted by AI