MINOR: [CI] Fix RC JNI builds on Windows (ArrowS3 link) and macOS (runner) - #1315
Merged
Merged
Conversation
jbonofre
changed the title
Member
Author
|
CI is green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Fix the
RCworkflow JNI builds, which have been failing onmainsince the Arrow C++maincheckout changed.dataset/CMakeLists.txt): Arrow C++ moved S3 into its own library (apache/arrow GH-50194).arrow_dataset_jnistill callsarrow::fs::EnsureS3Finalized()but no longer linked the library defining it, which failed withLNK2019: unresolved external symbol. LinkArrowS3::arrow_s3_staticwhen theArrowS3package is found, so builds against older Arrow C++ are unaffected..github/workflows/rc.yml): switch the runner frommacos-14tomacos-15. The Arrow C++ Brewfile installsllvm, which has no Homebrew bottle for macOS 14, sobrew bundlecompiled LLVM from source until the job hit the 1h timeout.MACOSX_DEPLOYMENT_TARGETstays at14.0.