Skip to content

fix: skip affected packages for "Not affected" Arch Linux AVGs #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sahil-u07 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: skip affected packages for "Not affected" Arch Linux AVGs #2457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vulnerabilities/pipelines/v2_importers/archlinux_importer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ def parse_advisory(self, record) -> AdvisoryDataV2:
summary = record.get("type", "")
summary = "" if summary == "unknown" else summary

for name in record["packages"]:
packages = record["packages"]
if record.get("status") == "Not affected":
packages = []

for name in packages:
affected = record.get("affected")
fixed = record.get("fixed")

Expand Down
17 changes: 17 additions & 0 deletions vulnerabilities/tests/pipelines/v2_importers/test_archlinux_importer_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,20 @@ def test_to_archlinux_advisories_v2(self):
pipeline.response = data
result = [adv.to_dict() for adv in pipeline.collect_advisories()]
util_tests.check_results_against_json(result, expected_file)

def test_not_affected_avg_has_no_affected_packages(self):
record = {
"name": "AVG-2737",
"packages": ["gnome-remote-desktop"],
"status": "Not affected",
"severity": "Unknown",
"type": "unknown",
"affected": "42.1-1",
"fixed": "42.1.1-1",
"ticket": None,
"issues": ["CVE-2022-1736"],
"advisories": [],
}
advisory = ArchLinuxImporterPipeline().parse_advisory(record)
self.assertEqual(advisory.affected_packages, [])
self.assertEqual(advisory.aliases, ["CVE-2022-1736"])