Repository navigation
Fix binary roundtrip and process ownership in #318 - #428
Draft
CaelmBleidd wants to merge 4 commits into
Draft
CaelmBleidd wants to merge 4 commits into
CaelmBleidd wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the gRPC/EtsIR prototype in #318 without changing its author's branch: copy the SDK file list, preserve valid Unicode strings through protobuf, keep await/yield result types and branch-order symmetry, and clean up owned processes/readers on timeout, interruption and server startup failure.
Base: #318 (
lipen/grpc). Head:315cfcd2c94b988b7a40a530ce4bec940bf73cf6.Validation: binary Wire encode/decode, DTO and server lifecycle checks passed 14/14 on the unchanged ETS correction at parent
6b1aa763ade14adb4ebb4fd2708fcffd0af988ab. The final buildSrc compatibility correction passes 5/5 process tests on Java 21; real Java 8 rerun compilation/tests pass 4 cases with 1 explicit descendant-capability skip. Java 8 supports parent cleanup/reaping/interruption; Java 9+ also terminates accessible descendants through a reflective public-interface bridge. Standard license hook and diff-check pass.This is a correction to the historical prototype, not an integration into current neo. Transport/architecture, current-base integration, actual gRPC/ArkAnalyzer execution and fresh test CI remain review gates. String roundtrip checks cover valid Unicode, with no promise of lone-surrogate preservation.