Skip to content

Fix EssentialsChat formatting lost when cloning chat packets - #50

Open
saboooor wants to merge 1 commit into
TerraByteDev:mainfrom
saboooor:main
Open

saboooor wants to merge 1 commit into
TerraByteDev:mainfrom
saboooor:main

Conversation

@saboooor

@saboooor saboooor commented Oct 10, 2026 •

Copy link
Copy Markdown

When InteractiveChat copies outgoing player chat packets on Minecraft 1.19.3 and later, the clone replaces unsigned formatted content with the raw signed message. This drops EssentialsChat formatting, including player names and prefixes.

Preserve the original optional unsigned content when cloning both the 1.19.3 and 1.21.5 packet variants. Also handle null signatures when copying modern chat packets.

Summary by CodeRabbit

  • Bug Fixes
    • Chat message cloning now preserves unsigned chat content for versions 1.19 through 1.21.5.
    • Cloning handles missing signature data without errors.

Copilot AI balanced review requested due to automatic review settings October 10, 2026 11:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c6211cf8-0485-460d-a5de-3ab5038010c8

📥 Commits

Reviewing files that changed from the base of the PR and between 344efcf and 41b84cc.


📒 Files selected for processing (1)
  • src/main/java/net/skullian/platform/PacketEventsOutMessagePacketHelper.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

Chat message cloning for versions 1.19 through 1.21.5 now preserves unsigned content. Signature arrays are copied safely, including when the input is null.

Changes

Chat Message Cloning

Layer / File(s) Summary
Preserve content and copy signatures
src/main/java/net/skullian/platform/PacketEventsOutMessagePacketHelper.java
Version-specific cloners pass unsigned content instead of getChatContent(). A new helper copies signature arrays and returns null for null input.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: loohp


Merge Risk: ⚪ Minimal · up to 41b84

The clone changes preserve optional chat formatting and handle absent signatures without an established merge-blocking issue.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: preserving EssentialsChat formatting when cloning chat packets.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants