You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix EssentialsChat formatting lost when cloning chat packets - #50
When InteractiveChat copies outgoing player chat packets on Minecraft 1.19.3 and later, the clone replaces unsigned formatted content with the raw signed message. This drops EssentialsChat formatting, including player names and prefixes.
Preserve the original optional unsigned content when cloning both the 1.19.3 and 1.21.5 packet variants. Also handle null signatures when copying modern chat packets.
Summary by CodeRabbit
Bug Fixes
Chat message cloning now preserves unsigned chat content for versions 1.19 through 1.21.5.
Cloning handles missing signature data without errors.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
Walkthrough
Chat message cloning for versions 1.19 through 1.21.5 now preserves unsigned content. Signature arrays are copied safely, including when the input is null.
Changes
Chat Message Cloning
Layer / File(s)
Summary
Preserve content and copy signatures src/main/java/net/skullian/platform/PacketEventsOutMessagePacketHelper.java
Version-specific cloners pass unsigned content instead of getChatContent(). A new helper copies signature arrays and returns null for null input.
The clone changes preserve optional chat formatting and handle absent signatures without an established merge-blocking issue.
Pre-merge checks | 4 | 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the main change: preserving EssentialsChat formatting when cloning chat packets.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When InteractiveChat copies outgoing player chat packets on Minecraft 1.19.3 and later, the clone replaces unsigned formatted content with the raw signed message. This drops EssentialsChat formatting, including player names and prefixes.
Preserve the original optional unsigned content when cloning both the 1.19.3 and 1.21.5 packet variants. Also handle null signatures when copying modern chat packets.
Summary by CodeRabbit