Repository navigation
Keep swipe to dismiss box until dialog is dismissed - #177
Merged
patrickunterwegs merged 4 commits intoOct 14, 2026
Merged
Conversation
- ListItem/TaskListItem: pass a stable onDismiss to SwipeToDismissBox. It re-invokes onDismiss whenever the lambda instance changes while the box is still dismissed, which re-opened the delete dialog after a recomposition of the caller. - List screens: swiping now always selects the entry (new ListAction.OnSwipeToDelete) instead of toggling it. Toggling deselected an already selected entry, so deletePending stayed false and the box never reset; with a single selection the dialog flag stayed set with no dialog shown. - DetailsViewModel: always clear deleteSubtaskId on confirm, even if editing is not allowed, so the dialog and swiped subtask can't hang. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KTnrG9jFBbwf8oPiZKq312
…solution is in place now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.