Skip to content

chore: disable semantic-release success comments #1014 - #1013

Closed
mart-sessman wants to merge 1 commit into
rcfrom
fix/158-release-success-comment
Closed

mart-sessman wants to merge 1 commit into
rcfrom
fix/158-release-success-comment

Conversation

@mart-sessman

@mart-sessman mart-sessman commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1014

Part of TEDI-Design-System/general#158

Sets "successCommentCondition": false on @semantic-release/github, so the success step no longer comments on the PRs and issues included in a release.

  • A reference to #0 (used on dependabot PRs to satisfy references-empty) fails the release: the plugin looks up every referenced number via GraphQL, and that lookup throws before successCommentCondition is evaluated. A condition like issue.number !== 0 cannot prevent it; skipping the step can.
  • The comments were never posted: the release job's token has no issues / pull-requests write permission, so every attempt logs "Not allowed to add a comment to the issue/PR".

Core already has success comments off.

Cross-repo issue links

The release config moves from .releaserc.json to release.config.mjs, so it can hold functions. The Angular preset links every #123 in a commit subject to this repo's issues, which turned TEDI-Design-System/general#252 into a link to this repo's issue 252. A writerOpts.finalizeContext hook now points owner/repo#123 references at the repo they name:

* add NOTICE for fonts [TEDI-Design-System/general#252](https://github.com/TEDI-Design-System/general/issues/252) ([aaaaaaa](...))

@mart-sessman mart-sessman self-assigned this Oct 20, 2026
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: TEDI-Design-System/react/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 32a20e77-16fc-4289-9c19-38d3cca0c4c0
📥 Commits

Reviewing files that changed from the base of the PR and between 393df67 and 7ef0f47.

📒 Files selected for processing: 1
  • .releaserc.json
+------------------+
| X marks the bug. |
+------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The success step looks up every referenced issue via GraphQL, so a reference to #0 fails the release before any condition is evaluated. The comments were never posted anyway: the release job has no issues or pull-requests write permission.
@mart-sessman
mart-sessman force-pushed the fix/158-release-success-comment branch from 7ef0f47 to 950c1bf Compare October 20, 2026 07:56
@mart-sessman
mart-sessman deleted the fix/158-release-success-comment branch October 20, 2026 07:56
@mart-sessman mart-sessman changed the title chore: disable semantic-release success comments TEDI-Design-System/general#158 chore: disable semantic-release success comments #1014 Oct 20, 2026
@mart-sessman

Copy link
Copy Markdown
Contributor Author

Closed by a branch rename, replaced by #1015

@github-actions

Copy link
Copy Markdown

♿ Accessibility — ✅ no blocking violations

No accessibility violations in the components changed by this PR.

⚠️ Pre-existing — 1 violation in components not changed here (warn only)

Component Rules Stories
TEDI-Ready/Components/Navigation/Tabs unknown 1
Stories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release config: fails on a reference to #0, cross-repo issue links point to the wrong repo

1 participant