Repository navigation
Add a SortingAnalyzer fixture to the cross-version serialization tests - #4876
Merged
alejoe91 merged 1 commit intoOct 19, 2026
Merged
Conversation
Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
alejoe91
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a peel-off of Alessio's serialization fixture from #4260 to simplify it. The files are identical to their versions there, so merging main into that branch produces no conflicts for them.
I am doing this first because #4260 changes the on-disk format of the
SortingAnalyzer, and I want a test on main that analyzers saved by released versions still load before that lands. The fixture saves an analyzer with every extension in each old release and checks that all of them reload with their data.It already caught a bug on main:
spiketrain_metricssetsneed_backward_compatibility_on_load = Truewithout implementing the handler, so any analyzer with that extension fails to load, even one saved by main. I set the flag toFalse, as in #4260.