Repository navigation
chore(pi-tui): sync vendored pi-tui to upstream v1.3.0 - #380
Merged
Merged
Conversation
Three-way merge from v1.0.1 (a7229ddc) to v1.3.0 (71023aec). Keeps the fork divergences; the set of files that differ from upstream is unchanged. Adds Terminal.setProgramStatus stubs to app test terminals.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirement or Bug
Sync the vendored
packages/pi-tuito upstreamearendil-works/piv1.3.0 (from v1.0.1).Bug Reproduction Steps
N/A
Root Cause
N/A
Code Changes
Three-way merge per file from the old sync point
a7229ddc(v1.0.1) to71023aec(v1.3.0), keeping fork divergences.UPSTREAM.mdrecords the new sync point.program-status.tsand its test), 4 had conflicts that I resolved by hand:README.md: upstream text, with our@pymodel/pi-tuipackage name.src/terminal-image.ts: upstream Herdr detection, with bracketprocess.env['KITTY_WINDOW_ID'].test/editor.test.ts,test/tui-render.test.ts: kept both fork and upstream imports and tests.process.env['PI_PROGRAM_STATUS'](TS4111).Terminal.setProgramStatus()required, so 7 app test stubs gained a no-op.docs/reference/keyboard.md: documented the Home/End and Ctrl-Home/Ctrl-End keys.diff -rqagainst the upstream tag lists the same 56 divergent files as before the sync, so no new drift. Upstream did not change the native sources or prebuilds in this range.Upstream highlights (v1.0.3 to v1.3.0): Program Status Protocol (OSC 7501),
renderFakeCursor(), a fix for fragmented terminal color replies leaking hex into the prompt, Herdr image and link support, shifted-symbol key bindings,Box/Text.setPaddingX, and overlay cursor and wheel-scroll fixes.Behavior Changes and Affected Users
Home/End, fullscreen modeCtrl-Home/Ctrl-EndCtrl-Home/Ctrl-End, fullscreenHome/End/Ctrl-A/Ctrl-Estill move the cursorHome/EndCtrl-Home/Ctrl-End, inline modeHome/End/Ctrl-A/Ctrl-EshowHardwareCursorPI_PROGRAM_STATUS=0Affected modules:
packages/pi-tui(ships inside the CLI) andapps/pythinker-codetests. Coverage:node --test: 1143 pass, 0 fail, 1 skipped (mainalso skips 1). This includes upstream's new tests for program status, stdin buffering, keys, fake cursor, and alt screen.tscandtsgoclean; vitest 4170 passed, 2 skipped.pnpm dev:cliin tmux; typinghello, thenHome, thenXgivesXhello.packages/pi-tui, so the package is not linted.Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.