fix(web): delete sidebar sessions through the session action - #331
Merged
Merged
Conversation
Sidebar delete called HTTP DELETE. The daemon only accepts POST /sessions/{id}:delete, so the desktop app showed a daemon error and left the session in place.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: PyModel/pythinker-code/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (19)
💤 Files with no reviewable changes (2)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughChangesSession deletion update
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Sidebar session deletion now uses the daemon’s supported action endpoint, and the rebuilt web assets reference the updated modules. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 215 functions across 13 files. (3 skipped: 3 unsupported.)
Comment |
commit: |
Merged
elkaix
added a commit
that referenced
this pull request
Sep 25, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @pymodel/pythinker-code@2.2.1 ### Patch Changes - [#331](#331) [`ea4bdd6`](ea4bdd6) Thanks [@elkaix](https://github.com/elkaix)! - Fix deleting a session from the sidebar. - [#329](#329) [`98235bb`](98235bb) Thanks [@elkaix](https://github.com/elkaix)! - Tower mode: mission titles must be printable ASCII, tower messages, findings, and reviews record the sender's token usage, and task cards show the mission id. ## @pymodel/pythinker-desktop@1.3.1 ### Patch Changes - [#331](#331) [`ea4bdd6`](ea4bdd6) Thanks [@elkaix](https://github.com/elkaix)! - Fix deleting a session from the sidebar. - [#329](#329) [`98235bb`](98235bb) Thanks [@elkaix](https://github.com/elkaix)! - Tower mode: mission titles must be printable ASCII, tower messages, findings, and reviews record the sender's token usage, and task cards show the mission id. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mohamed Elkholy <melkholy@techmatrix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No tracked issue. Reported from the desktop app: sidebar delete showed "Pythinker daemon returned an error" and left the session in place.
Problem
Deleting a session from the sidebar failed in about 15ms. The session stayed in the list. The dialog had no error code and no daemon message.
What changed
The web client now posts the session delete action the daemon already implements. The shipped web bundle is rebuilt so the desktop app uses that call.
Permanent delete is unchanged. A busy-session guard and a design-system import are not in this change.
Checklist
/approve).gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.Summary
Risk
Verification
pnpm --filter @pymodel/pythinker-web exec vitest run test/daemon-client.test.ts— 17 passed.pnpm run build:web— copied the web bundle.daemon-client.test.tsnow expectsPOST /sessions/sess_1:deletewith an empty JSON body.pnpm test, lint, typecheck, and Nix were not run. GitNexusdetect_changesreported medium risk onDaemonPythinkerWebApiand the load process.Rollback and review
Summary by CodeRabbit