Conversation
This was referenced Oct 4, 2026
Port the #590 Example 4 tests (spec stays in #590). The materialization adapter reads ingestion vs query time; retention_ms derives the kept span as Stage 3 prices it ((N + 1) panes, or two windows). Passing and un-ignored: ingestion-time upstream is ingestion time, nothing at ingestion over data at rest, materialized output covers its consumers, and B1 builds at ingestion and merges at query time; plus a new test that the tumbling KLL yields B1 and B2. Still ignored, with reasons: the Exponential Histogram (Pattern A), B3 (query time, kept), sliding windows, and the two Pattern B cost directions the built-in model contradicts (B2 misses the 200 ms bound; B1's retained per-series KLLs cost 768/s). stage_pipeline gains --example planner-layering-4a (Pattern A repeated monthly, Predictable): nothing is maintainable and 3a's plan is selected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/509-x5-stage2-materialization
branch
from
October 5, 2026 06:21
ec82a21 to
78cf83f
Compare
zzylol
force-pushed
the
stack/509-x5b-example4-acceptance
branch
from
October 5, 2026 06:21
25d2af0 to
215ed9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: Wave 2 chain: #599 → #601 → #600 → #604 → #606 → #603 → #605
Rebased on main d4869a7 (DF 54).
Stacked on #604. Part of #580 (step 5); #509 Example 4. Ports the #590 Example 4 acceptance tests. The spec doc stays in #590.
Why
#590's Example 4 tests could not run before Stage 2 had materialization. Their
materializationandretention_msadapters were stubs.What
planner_layering_example4.rsis ported from test: #509 Examples 2–4 acceptance specs and end-to-end tests #590.planner_layering_common:materialization(p, node)reads ingestion time or query time.QueryTimeKept(B3) is not generated.retention_ms(p, node)derives the kept event-time span the way Stage 3 prices it:(N + 1)·w;The export does not record retention yet.
assert_stage2_bijectionnow asserts one all-query-time candidate per logical candidate.stage_pipeline --example planner-layering-4a: Pattern A repeated monthly,Predictable { known_at: T }, over mixed data. It differs from 3a by recurrence only. Pattern B is identical toplanner-layering-3b, so there is no 4b.Before / After
Example 4 selections under the built-in models:
planner-layering-4a): the same 486 candidates, none maintainable (windows of 1–5 y are longer than a month, and no pane width gives ≤ 64 panes). Selects P365 at 54.34 cost/s, against 39,128 for the ad hoc batch amortized over 1 h.Gate
cargo fmt --all --check,cargo clippy --workspace --all-targets --all-features -- -D warnings,cargo test --workspace: 1,636 passed / 23 ignored (#604: 1,630 / 12; +5 passing and +11 ignored from Example 4, +1 devtool). Viewer: 29 OK.Links: #509, #580, #590, #594, #601, #604.
🤖 Generated with Claude Code