Repository navigation
Conversation
One design document for the edge schema of ASAP primitives: fields that carry summary state, the summary semantics a schema must preserve, coverage, and per-operator examples. Related docs keep a summary and link to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
Oct 3, 2026
The design document and the docs it consolidates are reviewed separately on main. This PR keeps code, tests and the ScanSelection rename in docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep the author's sections 1–4 as written; the operator examples (§5) and key code interfaces (§6) stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follows #579: the top-k sketch readout derives one row per selected item instead of a packed Utf8 column, matching the exact Sort → Limit shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
Oct 6, 2026
The design document and the docs it consolidates are reviewed separately on main. This PR keeps code, tests and the ScanSelection rename in docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…chema Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
added a commit
that referenced
this pull request
Oct 6, 2026
* feat(ir): define joint summary observation coverage * refactor(ir): name represented observations ObservationExtent * refactor(ir): rename observation extent to SummaryCoverage and trim its fields Name the metadata coverage to match #560 and the docs; drop the single-variant multiplicity and deployment-specific revision; rename grouping to reduction to match SummaryAgg; report failures through SchemaDerivationError::Coverage; revert the unrelated PaneCoverageError rename. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(ir): describe coverage source as any observation data source Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(ir): require coverage on summary nodes; allow regions without time bounds validate_structure rejects a SummaryAgg without coverage (CoverageError::Missing). CoverageRegion time bounds become optional so tabular sources without a time column can declare coverage. Population stays trusted; #570 tracks checking it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: explain the summary coverage problem with examples Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(ir): keep only time and population in SummaryCoverage Given required coverage on summary nodes, input and reduction duplicated the producing SummaryAgg fields; drop them along with ProducerMismatch. Type source as Source, matching Scan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(cost): rename SourceCoverage to ScanSelection SourceCoverage names the rows a physical scan reads for cost comparison, not which observations a summary state holds; rename it so it is not confused with SummaryCoverage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: turn summary coverage into a design document Move it to docs/design_docs/proposals with problem and motivation, requirements, design, alternatives and key code interfaces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: design doc for ASAP primitive schema and summary semantics Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Update asap-primitive-schema.md * Update asap-primitive-schema.md * Update asap-primitive-schema.md * Update asap-primitive-schema.md * docs: add code interfaces and per-operator examples to the ASAP primitive schema design Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: move the ASAP primitive schema design to #573 The design document and the docs it consolidates are reviewed separately on main. This PR keeps code, tests and the ScanSelection rename in docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(ir): say coverage time is absolute and population is Utf8 equality Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(ir): carry summary coverage through CSE and flat DAGs Coverage is part of a summary state's identity: two states over different observations are never shared, so CSE hashes and compares it, and a flat node keeps it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ASAP primitives (summary states such as KLL, Count-Min or exact accumulators) flow along DAG edges next to raw values. A
Schemadescribes what an edge is (fields and state types), but not which data a summary summarizes. So two states with identical schemas can still be wrong to merge or reuse, for example overlapping time windows or the same population counted twice. The design for this was split across several docs; this PR collects it into one design document.What
docs/design_docs/proposals/asap-primitive-schema.md. It covers:FieldDataType) and the state vs value boundary.OperatorNode.coverage.SummaryAgg,SummaryEstimate,FinalizeExactAccumulator,MaintainPopulation,EvaluatePopulation,SummaryMerge, and the reserved ones).operator-sharing.md§2.1,pre-asap-ir.md(fields and column references),asap-aware-mapping-contracts.md(sketch family identity), andphysical-planning-and-deployment.md(input vs summary semantics).decoupling_op_and_expr.md,concepts/post-asap-ir.md,univmon-frequency-summary.mdand the proposals index.Before / after
Related code:
SummaryCoverageis implemented in #567, andSummaryMergein #560. This PR is documentation only and based onmain.🤖 Generated with Claude Code