Repository navigation
Document requests as a runtime prerequisite - #39
Conversation
Viron's EnvironmentService and LocationService, which main.py imports, import requests, but the README only told readers to install pygame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Self-review rubric (one intrinsic pass; anchor:
Judgment call recorded: README.md:88: the Python 3.10+ minimum looks overstated; 3.9 is the likely floor. This is noted in the PR body and left unchanged, because no 3.9 interpreter was available to confirm it. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
Summary
Stage A documentation accuracy sweep. One drift was found and is fixed here:
main.pyimports Viron'sEnvironmentServiceandLocationService, and both modulesimport requests(Viron/src/main/python/preponderous/viron/services/environmentService.py:5,locationService.py:3). The README's Prerequisites and Setup sections only said to install Pygame, so following them literally ends inModuleNotFoundError: No module named 'requests'whenpython main.pyis run. Requests is now listed as a prerequisite, and the setup command installs it alongside Pygame.Everything else in the README and the batch scripts was checked against the source and found accurate: the CLI arguments and fallbacks in
parseArgs, theenvironments.jsonkey format, the 800x800 resizable window and 60 FPS cap, theRenderWindowAPI (close(), context manager,resizable), thecreate_environments.bat/up.bat/down.batcommands, theTestsworkflow description, the headless harness scenarios, and the usage-reporting section.One further observation is recorded but not changed: the README states Python 3.10+ is required. Static inspection suggests the real lower bound from the Viron import chain is 3.9 (the newest syntax found is the PEP 585
list[Environment]annotation atenvironmentService.py:16, which fails on 3.8). No 3.9 interpreter was available to confirm this, so the stated minimum is left as it is; stating a version that is too high is conservative and does no harm.Test plan
python3 -m py_compile main.py graphik.py __init__.pypassespython3 -m unittest discover -s tests: 123 tests ran, OK (Python 3.8.10; docs-only change, so this only confirms nothing else was disturbed)requestsimport was confirmed by reading the two Viron service modules, and by importingenvironmentServicewithrequestsstubbed outREADME.mdchanges, and no Docker is available in this environment to run Viron.Deferred issues
No tracking issue: the gap was found during the documentation sweep.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson