Skip to content

Add #sign block-group - #1024

Merged
Intelli merged 3 commits into
PlayPro:masterfrom
CloudM1nd3:master
Oct 2, 2026
Merged

Intelli merged 3 commits into
PlayPro:masterfrom
CloudM1nd3:master

Conversation

@CloudM1nd3

@CloudM1nd3 CloudM1nd3 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Created #sign block group to easely find all signs that was placed or broke.

For example, u needed to use sign action to find signs that was changed, teleport to them and then find information about sign-block.
Now u can simply use /co lookup action:block include:#sign time:1d radius:50 to find all signs was placed/broken in a radius.

@netlify

netlify Bot commented Sep 25, 2026

Copy link
Copy Markdown

❌ Deploy Preview for coreprotect failed. Why did it fail? →

Name Link
🔨 Latest commit 2c7935d
🔍 Latest deploy log https://app.netlify.com/projects/coreprotect/deploys/6ab63e6857a5d300083cb3bd

@Intelli

Intelli commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! A sign block group would be useful, but a few changes are needed before merging:

  • Please use #sign to match the PR description/example and the existing singular group names.
  • Populate the group using the existing version-aware sign detection (BukkitAdapter.ADAPTER.isSign(...)) instead of hardcoding newer Material constants. Those constants cause NoSuchFieldError during initialization on older supported servers. The current list also omits CRIMSON_WALL_SIGN, CRIMSON_HANGING_SIGN, and CRIMSON_WALL_HANGING_SIGN.
  • Remove TRACK_ANY.addAll(SIGNS). This changes block-break logging independently of the filter and can incorrectly record a standing sign as broken when an adjacent, non-supporting block is removed. Existing attachment tracking should remain unchanged.

@CloudM1nd3

Copy link
Copy Markdown
Contributor Author

In that case, I completely removed the hardcoded list of sign types; I hope this is the definitive solution

@Intelli
Intelli merged commit 00e7b38 into PlayPro:master Oct 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants