Skip to content
This repository was archived by the owner on Jul 27, 2024. It is now read-only.
This repository was archived by the owner on Jul 27, 2024. It is now read-only.

Facets overview rendering strangeness in Edge browser. #9

Description

@minimaxir

From loading the Quick, Draw demo in macOS 12.10.5 / Safari 10.1.1. (also occurs on Safari iOS).

Activity

  1. bengiswex commented on Jul 18, 2017

    @bengiswex

    Thanks for bringing this to our attention. We were able to reproduce that the demos don't work in Safari. For now, you can workaround by viewing them in Chrome. Will fix for Safari ASAP.

  2. valentas-kurauskas commented on Jul 18, 2017

    @valentas-kurauskas

    It seems I have the same problem with Firefox 54.0 & Ubuntu 16.04. The Jupyter Overview_demo renders no output as well.

  3. mg1075 commented on Jul 18, 2017

    @mg1075

    Cannot view demo in Microsoft Edge (Windows 10), either.

    Object doesn't support property or method 'getStatsProto'
    facets (286,5)

    image

  4. jameswex commented on Jul 19, 2017

    @jameswex
    Contributor

    @mg1075 @valentas-kurauskas @minimaxir please try the demo pages again on your non-chrome browsers.

    I updated the gh-pages branch demo code that drives the demo pages (see commit c436483). The code now loads the webcomponents-lite polyfill (to support browsers that don't have the webcomponents standard built-in) and only loads the facets code once the polyfill is loaded.

    It will still be the case that using the visualizations in jupyter will only currently work in Chrome, but the demo pages should be cross-browser compatible now.

  5. mg1075 commented on Jul 19, 2017

    @mg1075

    @jameswex - Microsoft Edge, Windows 10:
    the visualizations do show up now.

    I see odd behavior with the "log | expand | percentages" menu.
    First it shows at top. The "Chart to show" option is not visible.
    Then if I click a checkbox, the section moves to its normal spot, and the "Chart to show" option becomes visible.

    image

    image

    Here's a view from the console.

    image

  6. changed the title [-]Demo does not load in Safari: "Can't find variable: d3"[/-] [+]Facets overview rendering strangeness in Edge browser.[/+] on Jul 24, 2017
  7. jameswex commented on Jul 24, 2017

    @jameswex
    Contributor

    Changed the title of this issue as the initial issue is solved and now the remaining issue is an issue with some of the control positions in the Edge browser.

  8. jeremysalwen commented on Apr 24, 2018

    @jeremysalwen

    @jameswex Firefox 57, Debian Linux:

    The demo page works for me (https://pair-code.github.io/facets/) but the jupyter notebook integration doesn't display at all for me.

  9. jameswex commented on Apr 24, 2018

    @jameswex
    Contributor

    @jeremysalwen do you have errors in your developers console (assuming you are in chrome?)? Most likely the facets-dist jupyter extension wasn't installed in the place that the code in that notebook is expecting.

  10. jeremysalwen commented on Apr 26, 2018

    @jeremysalwen

    @jameswex I am on Firefox 57, I will check for console errors tomorrow.

  11. avilella commented on May 3, 2022

    @avilella

    The only issue I could see are the downloading of the of fonts, but the page looks fine on Firefox 99.0.1 (64-bit) Windows

    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions