Skip to content

perf: avoid per-row snapshot hash tuple copy - #29

Merged
TonisOrmisson merged 1 commit into
mainfrom
audit/workflow-execute-snapshots
Sep 9, 2026
Merged

TonisOrmisson merged 1 commit into
mainfrom
audit/workflow-execute-snapshots

Conversation

@TonisOrmisson

Copy link
Copy Markdown
Contributor

Summary

  • Use SQLAlchemy Row slicing directly in the normative relation-snapshot hash loop.
  • Remove one redundant tuple(row) allocation per streamed case row.
  • Preserve all snapshot hash calls, typed binary64/NULL/string encoding, execution atomicity, and public outputs.

Evidence

Fresh disposable SQLite execution workload, Python 3.13.2 / SQLite 3.47.1, five repetitions per size:

parent/output rows baseline median candidate median change
50,000 1.707318 s 1.588952 s -6.9% / 1.07x
100,000 3.465342 s 3.118572 s -10.0% / 1.11x

Relation-hash call count stayed at 3. A 10,000-row fidelity comparison produced identical content_hash and input_hash values.

Checks

  • 414 passed, 9 skipped, 53 deselected
  • git diff --check
  • Local read-only review: no findings

No public API, dependency, dataset identity, or persistence model changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 864f09f7-1699-418a-8b74-2bfbcb43564c

📥 Commits

Reviewing files that changed from the base of the PR and between abdbd91 and 0d14767.

📒 Files selected for processing (1)
  • src/openstatspec/sql/workflow.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TonisOrmisson
TonisOrmisson merged commit 999f6fe into main Sep 9, 2026
29 checks passed
@TonisOrmisson
TonisOrmisson deleted the audit/workflow-execute-snapshots branch September 9, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant