Skip to content

perf: avoid discarded core relation hash during workflow registration - #28

Merged
TonisOrmisson merged 1 commit into
mainfrom
audit/workflow-sql-calls
Sep 9, 2026
Merged

TonisOrmisson merged 1 commit into
mainfrom
audit/workflow-sql-calls

Conversation

@TonisOrmisson

Copy link
Copy Markdown
Contributor

Summary

  • Avoid the full streaming relation-snapshot hash during core transformation registration; registration only needs the parent schema/lineage and never stores that hash.
  • Preserve early physical relation/column/ordinal validation with a qualified zero-row projection query.
  • Keep derived-parent integrity verification and all execution-time input hashes unchanged.

Evidence

Fresh SQLite registration workload, Python 3.13.2 / SQLite 3.47.1, five repetitions per size (workflow catalog setup excluded):

parent rows baseline median candidate median change
50,000 0.466701 s 0.050539 s -89.2% / 9.2x
100,000 0.907442 s 0.058390 s -93.6% / 15.5x

SQLAlchemy execute count remains 139; relation hash calls change from 1 to 0 during registration.

Checks

  • 414 passed, 9 skipped, 53 deselected
  • git diff --check
  • Local read-only review: no findings

No public API, dependency, dataset identity, or persistence model changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 05289e3e-b325-4366-973f-93d97b305516

📥 Commits

Reviewing files that changed from the base of the PR and between 40466ea and 5eed10e.

📒 Files selected for processing (2)
  • src/openstatspec/sql/workflow.py
  • tests/test_sql_workflow.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TonisOrmisson
TonisOrmisson merged commit abdbd91 into main Sep 9, 2026
29 checks passed
@TonisOrmisson
TonisOrmisson deleted the audit/workflow-sql-calls branch September 9, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant