cleanup: remove unreachable view execution branch

[TonisOrmisson]

Summary

Remove the unreachable SQLite SQL transformation CREATE VIEW execution branch.

• Both registration and execution reject every non-materialized output before a run can reach the executor branch.
• Keep the existing materialized staging/query/rename/trigger/hash/publication path unchanged apart from dedenting it.
• Keep all actual view discovery/removal/reconciliation, catalog verification, in-place compensation and import cleanup. This does not remove supported recovery behavior or change capabilities/API modes.

Verification

• Commit 360df9e: one production file, no test changes.
• Base regression: 127 passed in tests/test_sql_workflow.py, tests/test_inplace_transform.py, tests/test_atomic_import.py.
• After change: same 127 passed.
• Full non-service suite: 408 passed, 9 skipped, 53 deselected.
• git diff --check: passed; tests/fixtures unchanged.
• Independent read-only full-diff review: No findings.
• All 29 GitHub checks successful, merge state CLEAN. CodeRabbit completed with no actionable comments/minimal risk; no review threads.
• @codex review was requested at 5599299165, but the service returned account usage-limit messages (5599299993, 5599301339) rather than running a review. No Codex result is claimed.

Scope proof

output_mode is rejected at registration and again before run insertion. The local mode value is not reassigned before the deleted branch, so the view arm was unreachable through supported public APIs. Existing conformance vectors and schema representation for view-capable contracts remain untouched; only execution of this adapter's already-rejected branch is removed.

After user merge: continue with the next approved cleanup candidate (PHP catalog UUID/preparation logic or specification checks). Do not auto-merge.

[TonisOrmisson]

@codex review

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 09684198-1e69-40e1-ae23-50c168ae0ebb

📥 Commits

Reviewing files that changed from the base of the PR and between 37658e4 and 360df9e.

📒 Files selected for processing (1)

• src/openstatspec/sql/workflow.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Changes

Transformation output materialization

Layer / File(s)	Summary
Unified materialized staging flow src/openstatspec/sql/workflow.py	execute_transformation now always creates and fills a staging table, validates the order key, renames the table to the derived relation, and creates immutability triggers. The view-based output_mode == "view" path was removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 360df

Transformation outputs continue to use the existing materialized staging and publication flow, while unsupported view execution is removed. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the unreachable view execution branch.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cleanup/remove-dead-ddl-branches

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}