Conversation
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1 and
ssrowe
September 26, 2026 00:12
mgaffigan
force-pushed
the
fix/command
branch
from
September 26, 2026 01:48
c9cd706 to
89adc9f
Compare
The client's connection monitor is a non-daemon thread, and runShell only closed the client on success. A refused connection, rejected certificate, or failed login printed the error and then hung forever. Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Nothing covered command end to end. The harness image now carries the CLI and runs it as a child process, so the distribution layout and launcher manifest are covered too. Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
fix/command
branch
from
September 26, 2026 02:01
89adc9f to
38705e8
Compare
Contributor
Author
|
Related #231 |
Member
I updated this PR as it already had considerable work done on it if we can review that one. It would only replace the first commit from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commandhangs instead of exiting when it cannot reach the server. The client'sconnection monitor is a non-daemon thread and
runShellonly closed the client onsuccess, so a refused connection, rejected certificate or failed login printed the
error and then sat there forever.
Also adds CI smoke tests for
command, which had no end-to-end coverage.Review notes:
exitsWhenServerIsUnreachableis the regression test - it fails as a 90s timeout if the hang returnscommandexits 0 whether or not it could log in#280 depends on this.