Repository navigation
Conversation
…18 baseline) <print> needs libstdc++ 14 and was the only reason numsim-core required GCC 14. print.h provides print/println with the same compile-time checked format strings on top of <format>, which libstdc++ 13 has. CI: gcc-13 and clang-18 (default libstdc++-13) join gcc-14 and clang-19.
- NUMSIM_CORE_BUILD_TESTS / _BUILD_EXAMPLES / _BUILD_BENCHMARK / _INSTALL replace the generic BUILD_* names that leaked into parent projects; the old names are still read with a deprecation warning; tests and examples default to ON only for the top-level project - namespace numsim::core, with `namespace numsim_core = numsim::core` so existing code keeps compiling - CMake helpers from numsim-cmake: GoogleTest via numsim_googletest(), tests via numsim_add_test (ASan+UBSan variants), warnings for examples
petlenz
force-pushed
the
refactor/options-namespace-cmake
branch
from
October 1, 2026 20:17
f429d32 to
df03895
Compare
Member
Author
|
Replaced by the single simplified PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #21 (its commits show here until #21 is merged).
What
NUMSIM_CORE_BUILD_TESTS,NUMSIM_CORE_BUILD_EXAMPLES,NUMSIM_CORE_BUILD_BENCHMARK,NUMSIM_CORE_INSTALL. The genericBUILD_TESTS/BUILD_EXAMPLESleaked into every parent project (numsim-materials even forces them OFF globally). Old names are still honoured with a deprecation warning. Tests/examples default to ON only when numsim-core is the top-level project.numsim::core, withnamespace numsim_core = numsim::core;(numsim-core/namespace.h, included by every header), so downstream code is unaffected. This matchesnumsim::materials,numsim::fft,numsim::homogenization.numsim_googletest()(installed or pinned v1.15.2 instead of an unpinned zip), tests throughnumsim_add_test(each test also runs under ASan+UBSan,-Wall -Wextra -Wpedantic -Wconversion -Werror), examples get the warning set.cmake/numsim_bootstrap.cmaketakes the modules from../numsim-cmakewhen present, else the pinned tag.Verified
122 tests (61 + sanitizer variants) with g++-13 and g++-14;
-DBUILD_TESTS=OFFstill works and warns.