Repository navigation
Constrain completion CPOs to non-const rvalue receivers - #2311
Open
emmett2020 wants to merge 4 commits into
Open
emmett2020 wants to merge 4 commits into
emmett2020 wants to merge 4 commits into
Conversation
Update receiver tests and fix affected calls in parallel_scheduler and receiver storage in merge_each.
ericniebler
reviewed
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standard requires calls to set_value, set_error, and set_stopped to be ill-formed when the
receiveris an lvalue or a const rvalue. The current implementations only check member callability and do not enforce these restrictions. This change adds the missing constraints and corresponding tests.The stricter constraints expose existing lvalue completion calls in
parallel_schedulerandmerge_each. The scheduler now passes its receiver as an rvalue. Inmerge_each, the next-sequence operation now stores a decayed receiver type to allow rvalue completion and avoid retaining a dangling reference:This MR also includes 4 unrelated formatting-only line changes required to pass the CI clang-format 21 check.