Rename Java multi-GPU PDLP settings to setUseMpdlp/setMpdlpPartitioner by ramakrishnap-nv · Pull Request #1981 · NVIDIA/cuopt

ramakrishnap-nv · 2026-09-23T15:06:42Z

Follow-up to #1961 (merged): a doc fix landed on that branch after the PR had already merged and never made it into main - re-applies it here. Also renames setUseDistributedPdlp/setDistributedPdlpPartitioner to setUseMpdlp/setMpdlpPartitioner, matching the mPDLP naming migration already applied to #1957 (Python) and #1962 (gRPC). Method names only; the underlying CUOPT_USE_DISTRIBUTED_PDLP/CUOPT_DISTRIBUTED_PDLP_PARTITIONER constants are unchanged (already-shipped C API).

Fixes #1931

🤖 Generated with Claude Code

Follow-up to NVIDIA#1961 (merged): completes the multi-GPU sharding sentence that landed on the fork after that PR had already merged, and applies the mPDLP naming migration (matching NVIDIA#1957/NVIDIA#1962) to the Java bindings. Method names only - the underlying CUOPT_USE_DISTRIBUTED_PDLP / CUOPT_DISTRIBUTED_PDLP_PARTITIONER constants stay unchanged, since they're generated from the already-shipped C API. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

copy-pr-bot · 2026-09-23T15:06:46Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Per team decision: documentation spells out "multi-GPU PDLP" in full (no abbreviations); "mpdlp" stays as the short form used in code identifiers only (setUseMpdlp, setMpdlpPartitioner, unchanged). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

ramakrishnap-nv · 2026-09-23T15:38:16Z

Same update as #1957/#1962: dropped "(mPDLP)" from doc/javadoc prose, kept mpdlp in the method names (setUseMpdlp, setMpdlpPartitioner).

github-actions · 2026-09-23T15:39:54Z

CI Test Summary

1 failed · 13 passed · 2 skipped

wheel-tests-cuopt / 12.2.2, 3.11, arm64, ubuntu22.04, a100, latest-driver, latest-deps — 1 failed test

tests/linear_programming/test_grpc_client.py::TestGrpcClient::test_mip_incumbent_stream@grpc_server

coderabbitai · 2026-09-23T15:44:46Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: NVIDIA/cuopt/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0b2c560b-b957-48f4-9e0f-bc47d76b86c0

📥 Commits

Reviewing files that changed from the base of the PR and between 39900e6 and b0def55.

📒 Files selected for processing (3)

docs/cuopt/source/cuopt-java/convex/convex-api.rst
java/cuopt/src/main/java/com/nvidia/cuopt/mathematicaloptimization/SolverSettings.java
java/cuopt/src/test/java/com/nvidia/cuopt/mathematicaloptimization/NativeIntegrationTest.java

Included review availability: Your plan provides up to 12 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The Java settings methods for multi-GPU PDLP use new names. Their documentation describes GPU-count behavior for sharding and partitioning. The integration test now calls the renamed methods.

Changes

Java mPDLP settings API

Layer / File(s)	Summary
Rename and document mPDLP settings `java/cuopt/src/main/java/com/nvidia/cuopt/mathematicaloptimization/SolverSettings.java`, `docs/cuopt/source/cuopt-java/convex/convex-api.rst`, `java/cuopt/src/test/java/com/nvidia/cuopt/mathematicaloptimization/NativeIntegrationTest.java`	The settings methods are renamed to `setUseMpdlp` and `setMpdlpPartitioner`. Their native setting writes remain unchanged. Documentation describes sharding and partitioner behavior when one or more GPUs are selected. The integration test calls the renamed methods.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to b0def

The Java API rename is reflected in its documentation and test, with no identified issue blocking merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Java method renames and matches the main changes in the pull request.
Description check	✅ Passed	The description accurately explains the documentation fix, Java method renames, unchanged native constants, and related API naming migration.
Linked Issues check	✅ Passed	For [`#1931`], the Java API retains multi-GPU PDLP support through the existing native settings. This PR renames the public setters to `setUseMpdlp` and `setMpdlpPartitioner`, keeps `CUOPT_USE_DISTRIBUT…
Out of Scope Changes check	✅ Passed	The changes are limited to the Java multi-GPU PDLP API names, related documentation, and the test that exercises the renamed methods. The changes support the linked issue and do not show unrelated beh…

Full details: Docstring Coverage

Explanation

Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (1 skipped: 1 unsupported.)

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

_{Comment @coderabbitai help to get the list of available commands.}

chris-maes · 2026-09-23T16:02:25Z

 * ``setOptimalityTolerance``;
-* ``setNumGpus``, ``setUseDistributedPdlp``, and ``setDistributedPdlpPartitioner``,
-  for distributing a PDLP solve across multiple GPUs. Distributed PDLP requires
+* ``setNumGpus``, ``setUseMpdlp``, and ``setMpdlpPartitioner``,


Remove setUseMpdlp. Does setMpdlpPartitioner need to be exposed in the API? Can this just be a regular parameter that is set like every other regular parameter?

…ITIONER; remove CUOPT_USE_DISTRIBUTED_PDLP (#1984) Per team naming discussion: CUOPT_DISTRIBUTED_PDLP_PARTITIONER -> CUOPT_MULTIGPU_PDLP_PARTITIONER (avoids confusion with the existing D-PDLP solver), and CUOPT_USE_DISTRIBUTED_PDLP is removed entirely since it was never meant to be user-facing (already hidden from --help). Dispatch is now purely method == PDLP && (num_gpus == -1 || num_gpus > 1); the internal use_distributed_pdlp C++ field stays as implementation bookkeeping. Also fixes the already-merged Java bindings (#1961), which referenced both constants directly. Breaking change to the C/C++/CLI surface (introduced ~2 months ago in #1391, author-described as internal). #1957, #1962, and #1981 alias to the old names and will need a follow-up once this merges. Fixes #1931 🤖 Generated with [Claude Code](https://claude.com/claude-code) Authors: - Ramakrishna Prabhu (https://github.com/ramakrishnap-nv) Approvers: - Bulle Mostovoi (https://github.com/Bubullzz) - Ishika Roy (https://github.com/Iroy30) URL: #1984

ramakrishnap-nv · 2026-09-29T14:22:17Z

Superseded by #1984 (which already removed setUseDistributedPdlp and renamed the partitioner setter) and #2000 (which removes these named setters from the Java API entirely). Closing.

This was referenced Sep 23, 2026

Expose multi-GPU PDLP settings in the Python API #1957

Closed

Fix distributed (multi-GPU) PDLP dispatch for the gRPC server #1962

Open

ramakrishnap-nv marked this pull request as ready for review September 23, 2026 15:34

ramakrishnap-nv requested a review from a team as a code owner September 23, 2026 15:34

ramakrishnap-nv requested a review from tmckayus September 23, 2026 15:34

ramakrishnap-nv self-assigned this Sep 23, 2026

ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Sep 23, 2026

ramakrishnap-nv added this to the 26.10 milestone Sep 23, 2026

chris-maes reviewed Sep 23, 2026

View reviewed changes

ramakrishnap-nv mentioned this pull request Sep 23, 2026

Rename CUOPT_DISTRIBUTED_PDLP_PARTITIONER to CUOPT_MULTIGPU_PDLP_PARTITIONER; remove CUOPT_USE_DISTRIBUTED_PDLP #1984

Merged

ramakrishnap-nv closed this Sep 29, 2026

Navigation Menu

Rename Java multi-GPU PDLP settings to setUseMpdlp/setMpdlpPartitioner - #1981

Rename Java multi-GPU PDLP settings to setUseMpdlp/setMpdlpPartitioner#1981
ramakrishnap-nv wants to merge 2 commits into
NVIDIA:mainfrom
ramakrishnap-nv:fea-1931-mpdlp-java-naming

ramakrishnap-nv commented Sep 23, 2026

Uh oh!

copy-pr-bot Bot commented Sep 23, 2026

Uh oh!

ramakrishnap-nv commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 23, 2026

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

chris-maes Sep 23, 2026

Uh oh!

ramakrishnap-nv commented Sep 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ramakrishnap-nv commented Sep 23, 2026

Uh oh!

copy-pr-bot Bot commented Sep 23, 2026

Uh oh!

ramakrishnap-nv commented Sep 23, 2026

Uh oh!

github-actions Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Test Summary

Uh oh!

coderabbitai Bot commented Sep 23, 2026

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

chris-maes Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

ramakrishnap-nv commented Sep 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Sep 23, 2026 •

edited

Loading