Repository navigation
security: escape attacker-controlled data in both dashboards, bump rustls - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two stored XSS sinks reach the dashboards from data any holder of a self-generated keypair can register or send: the admin node cards and the fetch queue in ui.html (no esc helper existed in that file at all) and the coverage tooltip, detail panel, band chips and quarter labels in beacon.html, where the existing esc helper was used only on the leaderboard paths. This escapes all of them, adds a safeHref helper so a javascript URI cannot pass where escaping alone would not stop it, and rejects nothing else - no behaviour change beyond escaping. Separately bumps rustls to 0.23.45 and rustls-webpki to 0.103.15, clearing RUSTSEC-2026-0285 and the webpki advisories; the h2, quinn-proto, hickory-proto and ring advisories remain because libp2p 0.54 pins them and they need a libp2p upgrade. Verified: cargo build --release clean, cargo test 187 passed 0 failed 1 ignored, and all nine inline script blocks pass node --check - the Rust compiler does not see a JS syntax error in these include_str assets, so that check is not optional.