Repository navigation
Android: sheet gestures, centred title (#212) - #213
Merged
Merged
Conversation
Take the handle pill and the page padding from the gjsify theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #212.
Takes the bottom sheet theme (drag handle pill, page padding) from gjsify. The gestures, the
partial sheet height and the centred title are in
@gjsify/adwaita-nativescript(gjsify#2078), so the shared
.blpfiles stay untouched.Needs gjsify#2078 (not released yet). type-check and install fail until then.
Seen on device (Tablet_API_36): tablet and 1080x2400 phone size, swipe up on the Help bar opens
to about 45 %, swipe down on the handle and tap outside close it, title centred.