Repository navigation
Conversation
|
Fails to build. Is that a workflow problem or a problem in your code? |
|
It looks like this needs to be updated to a newer ant https://github.com/JOSM/JOSMPluginAction/blob/c50cad09202cc1bf610bf73a6f49ab211e935e66/.github/workflows/ant.yml#L38. Or I could override it here. (maybe roll to apache-ant-1.10.18?) |
|
I pushed an override just to see if that gets CI sorted out. I can pull it back out of course. |
|
The override should no longer be necessary. Please remove it. |
Looks like the workflow is failing due to looking for EDIT: That was probably deliberate; |
|
There are a few ordering issues in the tests (these also fail on an unmodified branch). LMK if you'd like me to sort through those in a separate PR. |
c0fb585 to
abe7e68
Compare
Got the tests "fixed". One that was consistently failing was probably due to another test, but syncing threads fixed it. |
…catalog The default source list currently fails to load at all: the overture catalog referenced from sources.json returns 403, and that IOException discarded every default source. The preferences then only show the "Loading" placeholder row, which has an empty URL but still counted as valid, so enabling it stored it as a source and every download failed with "MalformedURLException: no protocol:". * A blank URL is no longer a valid URL (MapWithAIInfo#hasValidUrl) * MapWithAILayerInfo#add ignores sources without a URL; this also drops already-stored broken entries on load * The placeholder row can no longer be enabled/activated * Downloads skip sources without a URL instead of throwing * A failing overture catalog only drops the overture sources
The pmtiles catalog used for the overture sources no longer exists (403). Overture now publishes releases at https://stac.overturemaps.org/catalog.json and tiles at https://overturemaps-extras-us-west-2.s3.us-west-2.amazonaws.com/tiles/<release>/<theme>.pmtiles When the source URL points at the STAC catalog, create the sources for the latest release. Only the last few releases are kept, so these sources have an id without the release in it; user entries then follow new releases instead of being dropped. The old catalog format is still supported. sources.json (pages branch) needs to point at the STAC catalog for this to take effect.
…a hardcoded bucket
The theme catalogs link to the tiles ("rel": "pmtiles", currently on
tiles.overturemaps.org), so follow root -> latest release -> theme and use
that link. Themes without a tiles link are skipped with a warning. This costs
one small (cached) request per theme, but means the plugin follows Overture
if the tiles move again.
The shared workflow defaults to apache-ant-1.10.15, which is no longer on downloads.apache.org, so setup-ant fails before anything is built.
abe7e68 to
59cdebe
Compare
|
In v850. Minus the ant bit. |
3 participants
Properly consume the new STAC feed from Overture.
We crawl through their endpoint to get the latest and then find the themes.