ci: switch test-deploy workflow from yarn to npm - #58
Open
ahmet-cetinkaya wants to merge 1 commit into
Open
ahmet-cetinkaya wants to merge 1 commit into
ahmet-cetinkaya wants to merge 1 commit into
Conversation
The repo has package-lock.json (npm), but the PR workflow cached and installed with yarn. 'Dependencies lock file is not found ... Supported file patterns: yarn.lock' failed every PR; node 18 was also EOL. Aligns with deploy.yml (node 20, npm ci, npm run build).
Deploying docs with
|
| Latest commit: |
349174b
|
| Status: | 🚫 Build failed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Özet
Her PR'de kırmızı görünen "Test deployment" workflow'unu düzeltir. Workflow npm tabanlı repoda
yarnile kurulum yapıyordu:Değişiklikler
cache: yarn→cache: npmyarn install --frozen-lockfile→npm ciyarn build→npm run buildnode-version: 18→20(EOL;deploy.ymlzaten 20 kullanıyor)deploy.yml(main deploy) zaten aynı komutları kullanıyor — bu PR yalnızca PR test workflow'unu onunla hizalar.Doğrulama
npm ci && npm run buildlokale alındı, build geçiyor (doküman PR'ında aynı komutlarla doğrulandı)docs.insurup.comGitHub Pages'ten servis ediliyor)