Skip to content

make UnableToConnectToPVException less confusing - #96

Merged
KathrynBaker merged 2 commits into
mainfrom
rerpha-patch-1
Oct 6, 2026
Merged

KathrynBaker merged 2 commits into
mainfrom
rerpha-patch-1

Conversation

@rerpha

@rerpha rerpha commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Description of work

wraps PV name in single quotes so it doesn't look like we're trying to connect to a PV with a trailing colon

probably ignore ruff errors for this one they were auto fixed so i just commited them

To test

Which ticket does this PR fix?

Acceptance criteria

List the acceptance criteria for the PR


Code Review

  • Is the code of an acceptable quality?
  • Are there unit tests in place? Are the unit tests small and test the a class in isolation?
  • Have the changes been documented in the release notes. If so, do they describe the changes appropriately?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.
  • How do the changes handle unexpected situations, e.g. bad input?
  • Has developer documentation been updated if required?

KathrynBaker
KathrynBaker previously approved these changes Oct 6, 2026
@rerpha

rerpha commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

sorry @KathrynBaker may need you to re-approve, i decided to fix the ruff issues in the end

@KathrynBaker
KathrynBaker merged commit a8a6c10 into main Oct 6, 2026
16 checks passed
@KathrynBaker
KathrynBaker deleted the rerpha-patch-1 branch October 6, 2026 14:37
@Tom-Willemsen Tom-Willemsen removed this from Tasks Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants