Repository navigation
Upgrade/php85 symfony74 - #88
Merged
Merged
Conversation
Move the Dockerfile to the project root and consolidate the various helper shell scripts (application.sh, archive.sh, loop-validate.sh) under bin/. Drop download-validator.sh, now handled by a composer post-install-cmd. Add compose.override.yaml and a Doctrine-managed database service to docker-compose.yml. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…Serializer 5 Bump composer dependencies (PHP ^8.5, Symfony 7.4.*, doctrine/orm ^3.7, jms/serializer-bundle ^5.0, phpunit ^11, phpstan ^2) and update code and config accordingly: annotations replaced by PHP attributes for routes, Doctrine entity mapping and console commands; Doctrine ORM 3 query builder API (setParameter, SortDirection); removal of the deprecated getDoctrine() controller helper in favor of injected EntityManagerInterface; Kernel routing configurator update; phpunit/phpstan config updated for their new major versions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Update @ignf/validator-client to v0.5.9 and copy-webpack-plugin to v14, and rebuild the vendored validator-client.js bundle and style-carto.css accordingly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The validator-cli.jar writes a document-info.json file alongside validation.jsonl when the "normalize" argument is enabled. Parse it into a new nullable documentInfo field on the Validation entity, so it is served as document_info by the existing API responses, the same way results already is. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…orts, unused code, exit expressions) Import DateTime/Exception/RuntimeException/ZipArchive/SplFileObject instead of referencing them by fully-qualified name; drop unused command parameters where possible; return the exit code from ProcessOneCommand's handleSignal() instead of calling exit() directly, letting Symfony's Console Application terminate the process; drop the dead exit() call in CsvReportWriter's error-control operator and unused $csvName loop variable; actually apply PdfReportWriter's intended error/warning/info group ordering instead of leaving $order unused; avoid the $_ENV superglobal in ValidatorCLI (Symfony's Process already merges the current environment); suppress the false-positive UndefinedVariable finding on Response::$statusTexts static property access. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Move the logs/results.csv/results.pdf/files.normalized/files.source endpoints (and their shared getDownloadResponse() helper) into a new ValidationFilesController, leaving ValidationsController with only the CRUD endpoints. This brings ValidationsController's phpmd coupling metric back under threshold after EntityManagerInterface was injected directly (Symfony 7 removed the getDoctrine() helper). Also fix ValidationsController's stale SerializerInterface type-hint: toArray() is declared on JMS's ArrayTransformerInterface, not SerializerInterface, which phpstan started flagging once JMS Serializer 5 tightened this interface split. Drop the now-unused Filesystem dependency in favor of plain unlink()/file_exists(), and shorten the $mimeTypeGuesserService property name to fit phpmd's LongVariable rule. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Move all local working-directory and persisted-storage file operations (staging the uploaded zip, unzipping, zipping normalized results, saving output to storage, removing local/persisted files) into a new ValidationWorkspace collaborator. This drops ValidationManager's direct dependency on Filesystem, ZipArchive, Process/ProcessFailedException and ValidationsStorage, bringing its phpmd coupling metric back under threshold. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…lient bundle @ignf/validator-client v0.5.9 switched its webpack build from a single bundle to code-splitting (runtimeChunk: 'single' + a vendors cache group), so validator-client.js alone no longer defines the global `validator` object referenced by demo.js -- causing "Uncaught ReferenceError: validator is not defined" in the browser and leaving the demo stuck on "Chargement...". Add the missing runtime.validator-client.js and vendors.validator-client.js script tags before validator-client.js, matching the load order used by the client package's own reference public/index.html. Also commit the regenerated chunk files and style-carto.css produced by the current v0.5.9 build (the previously committed validator-client.js was a stale single-bundle build predating this code-split). Verified by loading the running dev server page through jsdom: `validator` is now defined and the React demo app renders into #demo-wrapper with no console errors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…lt (DATA_DOWNLOAD_ENABLED)
…en processing and clean up dependencies
…ts, handle interrupted validations
…ntity and clean up config
floriancerizay
force-pushed
the
upgrade/php85-symfony74
branch
from
October 2, 2026 12:44
c34af51 to
c24373d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type de pull request
Est-ce que vous introduisez des changements cassants ?
Checklist