19.0.1: space tour popover buttons with flex gap instead of a sibling selector - #165
Merged
Merged
Conversation
…elector The injected `.gleap-tour-popover-navigation-btns button + button` rule has a bare `button` subject, so Chrome restyles sibling subtrees on DOM inserts anywhere in the host page. `gap: 4px` on the existing flex container gives the same spacing (and none when the Previous button is hidden). Fixes #164 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
boehlerlukas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.
The injected
.gleap-tour-popover-navigation-btns button + button { margin-left: 4px }rule has a barebuttonsubject, so Chrome restyles sibling subtrees whenever a node is inserted anywhere in the host page — the reporter measured ~2,000 extra elements restyled per interaction on a large app.The container is already
display: flex, so this addsgap: 4pxthere and drops the sibling rule. Same layout; additionally, when the Previous button is hidden (display: none), Next no longer keeps a stray 4px left margin. It was the only sibling combinator in the injected styles.Releases as 19.0.1: version bump, CHANGELOG entry and rebuilt
build/+published/.npm testpasses (781 tests).🤖 Generated with Claude Code