Repository navigation
Stop the cloned section cache cleanup at the first entry that has not expired - #576
Open
BonsUnleashed wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The cloned-section cache checks up to 512 entries every frame, even when none have expired. Its entries are already ordered by last use, so this stops at the first unexpired entry instead of scanning the rest. The five-second timeout and 512-entry limit stay the same.
This depends on the existing monotonic clock assumption. Checks against the compiled original and changed classes covered about 1.5 million cleanups, including invalidation and expiry boundaries, with matching contents and ordering.
The equivalent patch ships in Bons and Furious 1.0.26 for Embeddium 0.3.31. In its isolated benchmark, a full-cache cleanup dropped from about 770 ns to 45 ns; that is not a measured FPS gain.
Compiles on
20.1/forge(compileJava). Not tested in game on this branch.