build: pin fbuild 2.5.37 for ESP32-C2 and H2 - #4698
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Changesfbuild dependency pin
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The updated fbuild version is available for the project’s declared platforms, and no specific build regression is identified. No merge blocker is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #4687. Pins the released fbuild 2.5.37, which repairs the packaged ESP32-C2/H2 Bluetooth header paths and drops the unsupported C++ atexit flag for their SDK. Both Blink builds pass locally using the published wheel. The fbuild source fix passed its CI and was merged in FastLED/fbuild#1651; its exact-SHA release dry run and publish run both passed.
Summary by CodeRabbit