Skip to content

build: pin fbuild 2.5.37 for ESP32-C2 and H2 - #4698

Merged
zackees merged 1 commit into
masterfrom
fix/4687-sdk-header-paths
Oct 4, 2026
Merged

zackees merged 1 commit into
masterfrom
fix/4687-sdk-header-paths

Conversation

@zackees

@zackees zackees commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Fixes #4687. Pins the released fbuild 2.5.37, which repairs the packaged ESP32-C2/H2 Bluetooth header paths and drops the unsupported C++ atexit flag for their SDK. Both Blink builds pass locally using the published wheel. The fbuild source fix passed its CI and was merged in FastLED/fbuild#1651; its exact-SHA release dry run and publish run both passed.

Summary by CodeRabbit

  • Bug Fixes
    • Improved build compatibility for ESP32-C2/H2 Bluetooth headers and GCC 14 SDKs.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: FastLED/FastLED/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0226878d-0f6e-4f75-af88-f296f59381ca
📥 Commits

Reviewing files that changed from the base of the PR and between 367602a and 496af68.

📒 Files selected for processing (1)
  • pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The fbuild dependency pin changes from 2.5.36 to 2.5.37. The pin-history comments describe repairs and a compiler flag change associated with version 2.5.37.

Changes

fbuild dependency pin

Layer / File(s) Summary
Update fbuild pin
pyproject.toml
The dependency pin changes to 2.5.37. The pin-history comments describe ESP32-C2/H2 Bluetooth header-layout repairs and removal of -fuse-cxa-atexit for GCC 14 SDKs.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 496af

The updated fbuild version is available for the project’s declared platforms, and no specific build regression is identified. No merge blocker is established.

Architecture Summary

Architecture risk: 🔵 Low · up to 496af

The change affects 1 system.

Changed systems: pyproject.toml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — pyproject.toml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in pyproject.toml: The pin-history comments replace the 2.5.36 compatibility note with a 2.5.37 entry describing C2/H2 Bluetooth header-layout repairs and removal of -fuse-cxa-atexit for GCC 14 SDKs.
  • observed — Modified behavior in pyproject.toml: The pinned fbuild dependency changes from version 2.5.36 to 2.5.37.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the fbuild version pin and the ESP32-C2 and H2 targets, which summarize the main change.
Linked Issues check ✅ Passed Issue #4687 is closed, so it supplies historical context only and creates no active coding requirements for this pull request.
Out of Scope Changes check ✅ Passed The whole-PR diff only updates the fbuild pin and its history comments in pyproject.toml. The fbuild 2.5.37 entry ties the C2/H2 header-layout repair and atexit flag change to this pull request’s stat…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit ddf0bd4 into master Oct 4, 2026
119 checks passed
@zackees
zackees deleted the fix/4687-sdk-header-paths branch October 4, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Release blocker: fix ESP32-C2/H2 SDK header paths

1 participant