Repository navigation
Bind developer approval to the reviewed profile instance - #272
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
api | 314064e | Oct 07 2026, 03:26 AM |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 18 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Requires human review: Security fix binding approvals to profile generation and content revision, but it includes a data migration that clears all existing approvals and changes the approval API contract and moderation behavior, so deployment and policy decisions need human sign-off.
Turn on auto-fix | Re-trigger cubic
1 participant
Deleting and recreating a developer profile reused its ID and revision number, allowing a moderator's stale approval to approve replacement content. Approval now atomically checks the reviewed profile generation and content revision. The database assigns a fresh generation on every creation, including reused IDs.
Meaningful edits now clear manual approval for GitHub-verified profiles too. Profile reads, embedded extension developers, and the moderation queue consistently require approval of the current revision. Regression tests cover profile/account deletion, recreation immediately before approval, paused owner edits, invalid tokens, and public projections.