Repository navigation
Conversation
strub
added this pull request to stack #1156
October 6, 2026 21:31
strub
added
the
stacked
PR of the program-logic reorganization stack (see
src/phl/REFACTORING.md). It migrates the `symmetry` tactic class:
- rules/equiv/ecEquivSym.ml: the two trusted symmetry rules of the
equiv logic, for statements (`equiv [c ~ c' : P ==> Q]` from
`equiv [c' ~ c : P' ==> Q']`, the memory types exchanged as well)
and for procedures, where P' and Q' are P and Q with their two
memories swapped. Each is documented as an inference rule in the
.mli and emits a (parameterless) node with a registered checker
("equivS-sym", "equivF-sym"). The subgoal builder needs no
environment and the rules have no side condition.
- EcPhlSym is reduced to the dispatcher (interface unchanged), still
used by `symmetry` and `rewrite equiv`.
Behaviour is unchanged.
A new test, tests/sym-equiv.ec, exercises both rules (including
different local variables on each side) and the error paths; it
passes with the builds before and after this change. The stdlib and
the unit tests pass under EC_RECHECK=1 with no RecheckFailure; each
checker, when deliberately broken, is caught only under EC_RECHECK
(on the new test, and on the stdlib: equivS-sym 4 files, equivF-sym
4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR of the program-logic reorganization stack (see
src/phl/REFACTORING.md). It migrates the
symmetrytactic class:equiv logic, for statements (
equiv [c ~ c' : P ==> Q]fromequiv [c' ~ c : P' ==> Q'], the memory types exchanged as well)and for procedures, where P' and Q' are P and Q with their two
memories swapped. Each is documented as an inference rule in the
.mli and emits a (parameterless) node with a registered checker
("equivS-sym", "equivF-sym"). The subgoal builder needs no
environment and the rules have no side condition.
used by
symmetryandrewrite equiv.Behaviour is unchanged.
A new test, tests/sym-equiv.ec, exercises both rules (including
different local variables on each side) and the error paths; it
passes with the builds before and after this change. The stdlib and
the unit tests pass under EC_RECHECK=1 with no RecheckFailure; each
checker, when deliberately broken, is caught only under EC_RECHECK
(on the new test, and on the stdlib: equivS-sym 4 files, equivF-sym
4).