Skip to content

fix(vmm): expose failed starts through boot_error - #1428

Open
Leechael wants to merge 2 commits into
nextfrom
fix/vmm-start-diagnostics
Open

Leechael wants to merge 2 commits into
nextfrom
fix/vmm-start-diagnostics

Conversation

@Leechael

@Leechael Leechael commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

When netd preparation fails, StartVm returns an error but leaves boot_error empty.
Record the error chain in the existing boot_error field and set boot_progress to failed for explicit starts and automatic restarts, without changing the startup implementation.
An immediate FakeNetd rejection regression fails without the fix; validation: 217 tests passed (3 existing tests ignored), formatting and Clippy passed.
Network preparation errors now identify the netd method and socket, include the wait duration on timeout, and no longer blame queue counts for unrelated failures.

@Leechael
Leechael force-pushed the fix/vmm-start-diagnostics branch from 5dd48f0 to 53a94a5 Compare September 30, 2026 04:16
Signed-off-by: Leechael Yim <yanleech@gmail.com>
@Leechael
Leechael force-pushed the fix/vmm-start-diagnostics branch from 53a94a5 to d773d26 Compare September 30, 2026 04:45
@Leechael Leechael changed the title fix(vmm): preserve launch diagnostics and reconcile uncertain deployments fix(vmm): expose failed starts through boot_error Sep 30, 2026
Signed-off-by: Leechael Yim <yanleech@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant