Repository navigation
Conversation
pradeeban
pushed a commit
that referenced
this pull request
Oct 5, 2026
…follow-up) Extends the cross-runtime matrix from #440/#467 to cover cpp, which was still all not_audited. Traced concore.hpp/concore_base.hpp against the 8 phase-1 fixtures by hand: - both parse_params cases fail: load_params() globally replaces every ',' and '=' before building a dict literal, so any comma- or equals-containing value (an array literal, a URL) corrupts the conversion and load_params() silently returns an empty map - the mixed-type initval case fails: flatten_numeric() silently drops non-numeric elements, so a string in the payload disappears instead of being preserved, shifting the remaining values - the other 5 cases (empty-input initval, both write_zmq cases, both read_file cases) match Python's semantics Also wires TestLiteralEvalCpp.cpp and TestConcoreHpp.cpp into CI. Both files already existed (#389, #484) with proper pass/fail exit codes, but the only cpp CI job only ran -fsyntax-only on a different file, so these never actually executed and a regression in either would have stayed green. Report-only, no runtime behavior changed. Refs #440 #574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @pradeeban,
Following up on the discussion in #440 and Phase 1 conformance work, here is the PR for Phase 2 (mapping/audit).
As promised in our initial plan, this PR is strictly report only and non breaking. It introduces a language agnostic matrix to track how different runtimes handle the protocol cases we defined in Phase 1, without changing a single line of runtime logic anywhere.
What Changed
cross_runtime_matrix.phase2.json): Added phase 2 metadata (phase,mode,runtimes,classifications,statuses).python,cpp,matlab,octave, andverilog.not_auditedto ensure this phase remains purely observational.tests/test_protocol_conformance_phase2.py):python=observed_passbaseline.PROTOCOL_FIXTURES.md): Updated to clearly document the Phase 2 scope and constraints.Safety
Validation
python -m pytest -v tests/test_protocol_conformance.py tests/test_protocol_conformance_phase2.py→ 10 passedpython -m pytest -v tests --ignore=tests/test_openjupyter_security.py→ 99 passedEvidence
1) Phase-2 matrix metadata (report only + enums)
2) Example mapped case (Python observed, others pending)
3) Targeted conformance tests passing
4) Broader test run passing
Note to Maintainers
I kept this intentionally minimal and report only so we can review the matrix structure together before we start classifying how the other languages currently behave. let me know if this structure looks good to you.