Repository navigation
Reports moves under Advanced in gates 104 and 107 - #825
Merged
Merged
Conversation
…anced (gates 104, 107) Ruben decided on 2026-10-07 that the settings foldout is renamed Advanced and that Reports goes under it in every app (ADR-112 D3, ADR-114 D1 and D3, amended in hydra). gate-104 now requires the Reports entry in section "settings" and names the footer or the main menu when it is not. gate-107 moves Reports from the footer to settings and drops it from the footer sequence. Fixtures: the reports-one-page and app-chrome bundles follow the new rule (app-chrome's footer-order defect is now planted on Store). Two new bundles, reports-one-page-footer and app-chrome-reports-footer, differ in one field: Reports in the footer fails, Reports in settings passes.
rubenvdlinde
marked this pull request as ready for review
October 7, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruben decided on 2026-10-07 to rename the settings foldout to Advanced in every app, and to put Reports under Advanced in every app. The ADR amendments are in ConductionNL/hydra#742. This PR moves gates 104 and 107 to the new rule.
What changes
reports-one-pagestill enforces one Reports page. Its menu entry must now besection: "settings". In the footer or the main menu it fails, and the message names where it renders:the Reports menu entry is section:"footer", not "settings", so it renders in the footer. ADR-112 Decision 3, amended 2026-10-07: Reports is one entry in the settings foldout, labelled Advanced, not in the footer or the main menu.app-chromeplaces Reports insettings. It drops Reports from the footer sequence, which now reads Documentation, Store, Features & roadmap. A misplaced Reports names the amended rule.Fixtures
reports-one-page: the clean arm has Reports insettings. The planted arm's subject is nownot "settings", so it renders in the main menu.app-chrome: both arms carry Reports insettings. The footer-order defect is now planted on Store (order 200, below Features & roadmap), since Reports left the footer.reports-one-page-footer(gate 104) andapp-chrome-reports-footer(gate 107). In each, the arms differ in one field: Reports in the footer fails, Reports in settings passes.test-fixtures/reports-one-page/follow the rule, so each still fails only for its own reason.Verified
bash hydra-gates/scripts/lib/test_gate_acceptance_matrix.sh: exit 0, 266 passed, 0 failed.The old gates, as a control, fail both PR branches on gate-107 and buildiq's on gate-104, and pass both development branches.
Merge order
Merging this reds gate-107 on every app's development until its "Reports moves under Advanced" PR lands, and gate-104 on apps with a
type: "reports"page. Land this together with the 18 app PRs.Draft: the coordinator merges after Ruben has seen it.
🤖 Generated with Claude Code