Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
abmhts
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
abmhts
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
abmhts
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
abmhts
added
the
Needs Review
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Sep 26, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Nice effort, one minor issues needs fixing. Thanks
| // Finally, correct the code to fix the problem | ||
| // =============> write your new code here | ||
|
|
||
| function convertToPercentage() { |
There was a problem hiding this comment.
this fixes the issue, however the does the function still works correctly?
There was a problem hiding this comment.
Think about, when given an input can the does the function return the correct output?
Author
There was a problem hiding this comment.
The function wasn’t producing the correct output, but I’ve corrected it now. Thank you
hey-hammad
added
Reviewed
abmhts
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1053
Changelist
Completed Sprint 3 tasks including time formatting, BMI calculation, toPounds, getLastDigit, and square functions.
Also fixed return statements, naming conventions, and documented the errors, predictions, and solutions.