London | 26 ITP MAY | Russom Gebremeskel | Sprint 2 | Coursework by russom-g · Pull Request #1502 · CodeYourFuture/Module-JavaScript-Fundamentals

russom-g · 2026-09-11T21:42:21Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1039

Changelist

Using documentations errors explained fixed. Program explained step by step.

abdishakoor-dev

Your answers are clear and well explained. Your breakdown of line 4 in 2-time-format.js is very good, with real numbers at each step. 3-to-pounds.js step 3 also has good examples, with 11 and 1.

I have left a hint on each line. Please fix these things before I can mark this Complete:

1-percentage-change.js a) and 2-time-format.js b): both say there are no function calls. But both files have some. A function call is a function name followed by brackets, like name(...). For example, console.log(...) and Number(...) are function calls. Look for this pattern in each file, and count them again.
3-paths.js line 21: ext only works when the extension has 3 letters. The code on lines 13 and 14 shows you a better way. See my reply on line 21.
4-random.js: say what num is at the end.
2-mandatory-errors: 1.js has no explanation. 2.js and 4.js need the error type (SyntaxError, TypeError or ReferenceError). In 3.js, change line 2, not line 1.
2-time-format.js: answers c) and f).
"My changes follow the style guide" is on your checklist, and consistent formatting is part of it. The tool that does it is called Prettier. It sets spacing and indentation to one agreed style. Then a reviewer only sees the changes you meant to make. Right now all the files you changed fail that check.

Prettier comes with the CYF extension pack from onboarding. If you are not sure you have it, open VS Code, go to Extensions, and search for CodeYourFuture Extension Pack: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack

Then open each file you changed, right click in the editor, and choose Format Document. Pick Prettier if VS Code asks. Save, commit and push. To format every time you save, follow the format on save steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you have pushed.

abdishakoor-dev · 2026-09-23T15:42:54Z


-const age = 33;
+let age = 33;
 age = age + 1;


The fix works. But the exercise also asks you to explain the error. Please add a comment with the error type and the reason.

The prep shows three error types:

SyntaxError: the code breaks a rule of JavaScript, so no line runs.

TypeError: the code tries to do something that value cannot do.

ReferenceError: the code uses a variable it cannot reach.

When you ran the original file, node's error message started with one of these. Which one was it? And why does let fix it?

abdishakoor-dev · 2026-09-23T15:42:54Z

 const cityOfBirth = "Bolton";
+console.log(`I was born in ${cityOfBirth}`);
+
+// Java script cannot access the variable cityOfBirth before initialization.


Your reason is right, and the fix works. Please also write the error type.

The prep shows three error types:

SyntaxError: the code breaks a rule of JavaScript, so no line runs.

TypeError: the code tries to do something that value cannot do.

ReferenceError: the code uses a variable it cannot reach.

When you ran the original file, node's error message started with one of these. Which one was it?

abdishakoor-dev · 2026-09-23T15:42:54Z

+const twelveHourClockTime = "8:53pm";
+const twentyFourHourClockTime = "20:53";
+
+// Variable names cannot start with a number in Java Script.


Your reason is right, and the new names work. Please also write the error type.

The prep shows three error types:

SyntaxError: the code breaks a rule of JavaScript, so no line runs.

TypeError: the code tries to do something that value cannot do.

ReferenceError: the code uses a variable it cannot reach.

When you ran the original file, node's error message started with one of these. Which one was it?

abdishakoor-dev · 2026-09-23T15:42:54Z

+
+// b) There are no function calls.
+
+// c) The reminder (%) operator returns the reminder left over when one operand is divided by a second operand.


This is what % does in general. In this program, movieLength % 60 gives 24. Are those 24 seconds, minutes or hours? Write what the 24 means here.

abdishakoor-dev · 2026-09-23T15:42:54Z

+
+// e) result represents the length of the movie in hours, minutes, and seconds format. It can be renamed movieDuration.    
+
+// f) When displaying single digit hour, minute, or seconds it doesn't include 0 in front of the digit.


Good, that is one problem. Now try -90 and 90.5 as movieLength. What does the program print each time? Add what you see to f).

abdishakoor-dev

3-paths.js and 4-random.js are fixed now. Thanks.

Some changes you mention in the threads are not in the PR. For example, 2-time-format.js b) still says "There are no function calls". And 3.js has not changed since 16 September. Maybe the files were not saved, or not pushed. In VS Code, a dot on a file tab means the file is not saved.

Still to do:

1-percentage-change.js a): your lines are right. The question also asks how many calls. Line 4 has two. Write the total.
2-time-format.js b): line 10 has console.log(result). That is a function call. So the answer is 1.
2-mandatory-errors/3.js: go back to your first version on line 2, as in my thread reply. Line 1 stays a number.
2-mandatory-errors/1.js, 2.js and 4.js: add the error type to each. See my comments on those files.
2-time-format.js c) and f): see my comments on lines 33 and 39.
Prettier: most of the files you changed still fail the check. Format each one, then push. Format on save stops this coming back: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you have pushed.

russom-g · 2026-09-26T14:27:52Z

@abdishakoor-dev Everything is updated now.

github-actions · 2026-09-26T14:47:49Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-3/4-mandatory-interpret/.gitignore

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-09-26T14:47:52Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-3/4-mandatory-interpret/.gitignore

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

russom and others added 30 commits September 2, 2026 22:04

Update code from 26-ITP-MAY to 26 ITP-SEP for resubmitting

2d1b73d

validate error with w3.org

21df038

Lables and input and css created

2753312

Style seprated from html and contained in its own file.

56c0cf5

add regex to name label

148a95a

update name

406e215

update align author name centre

b9b3c99

link css file

a2f9b70

remove duplicate css file

06cd821

Centre submit button

05ec57a

Add css validation icon display

a6af01c

Describe line 3 code

e41c304

Update answer

d3a57b0

Implement charAt method

c302bc4

Create variable using slice method

e43b31e

Explain how the code works

9a013e1

Comment out non code comments

439f732

Reassign age variable

ed79f77

Initialize variable first

28e7901

Fix data type

50b1516

Fix variable name declaration

209739c

Answer question. Fix code. Add comma.

a613e4c

Answer question and explain.

fbade85

Explain how the program work

ee0394d

Explain code step by step.

b3f5ce4

Questions answered about alert and prompt on chrome

19404bf

Answer questions on console object

47c46d3

Format answers with numbers.

59a3ca0

Format answers with numbers.

171051e

Merge branch 'CodeYourFuture:main' into coursework/sprint-2

e0505a8

russom added 3 commits September 16, 2026 21:21

Change to robust slice method

0a6358a

Change number type to string to make it work edge cases.

6f5e1ca

Update Math.random method description

e9d4ba3

russom-g added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 23, 2026

abdishakoor-dev reviewed Sep 23, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 23, 2026

russom added 4 commits September 24, 2026 21:52

Update answers.

f0cd42a

Update answer

36f340d

Update code with lastIndexOf

03b641a

Update code with String(Number())

a2ebb1b

russom-g added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 26, 2026

abdishakoor-dev reviewed Sep 26, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 26, 2026

russom added 5 commits September 26, 2026 15:10

Update answer

cdbe5c4

Update code ti number from string.

aea31d0

Update answers

748d7c6

Update answer

23c5495

Format code with prettier

2cb48fa

russom-g added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 26, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 26, 2026

russom added 2 commits September 26, 2026 15:53

Remove file from repo, keep local copy

82dc3aa

Update

485bae0

Navigation Menu

Uh oh!

London | 26 ITP MAY | Russom Gebremeskel | Sprint 2 | Coursework - #1502

London | 26 ITP MAY | Russom Gebremeskel | Sprint 2 | Coursework#1502
russom-g wants to merge 46 commits into
CodeYourFuture:mainfrom
russom-g:coursework/sprint-2

russom-g commented Sep 11, 2026 •

edited

Loading

Uh oh!

abdishakoor-dev left a comment

Uh oh!

abdishakoor-dev Sep 23, 2026

Uh oh!

abdishakoor-dev Sep 23, 2026

Uh oh!

abdishakoor-dev Sep 23, 2026

Uh oh!

abdishakoor-dev Sep 23, 2026

Uh oh!

abdishakoor-dev Sep 23, 2026

Uh oh!

abdishakoor-dev left a comment

Uh oh!

russom-g commented Sep 26, 2026

Uh oh!

github-actions Bot commented Sep 26, 2026

Uh oh!

github-actions Bot commented Sep 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		// b) There are no function calls.

		// c) The reminder (%) operator returns the reminder left over when one operand is divided by a second operand.


		// e) result represents the length of the movie in hours, minutes, and seconds format. It can be renamed movieDuration.

		// f) When displaying single digit hour, minute, or seconds it doesn't include 0 in front of the digit. No newline at end of file

Uh oh!

Conversation

russom-g commented Sep 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Task code

Changelist

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

russom-g commented Sep 26, 2026

Uh oh!

github-actions Bot commented Sep 26, 2026

Uh oh!

github-actions Bot commented Sep 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

russom-g commented Sep 11, 2026 •

edited

Loading