Skip to content

Composer | Reopen recipient list on a second To/Cc click - #11

Merged
BrianGenisio merged 1 commit into
mainfrom
fix/recipient-picker-second-click
Oct 6, 2026
Merged

BrianGenisio merged 1 commit into
mainfrom
fix/recipient-picker-second-click

Conversation

@BrianGenisio

Copy link
Copy Markdown
Contributor

Summary

After you pick someone on To or Cc, the field stays focused. A second click on that field did not reopen the people list, so you had to click away and back first.

The row mousedown handler now reopens the list when the input is already focused.

Changes

The list used to open only on focus. Clicks on the input itself were ignored so the caret could land naturally. After a pick, focus never fires again, so the list stayed closed.

The handler still ignores chip-remove and option clicks. For a click on the already-focused input, it calls openRecipientMenu without preventDefault, so native caret placement is unchanged.

Test plan

  • Compose a new message
  • Click To, pick someone
  • Click To again without clicking elsewhere. Remaining people should appear
  • Pick a second person, then click To a third time. The list should open again
  • Repeat the same flow on Cc
  • Removing a chip should still only remove that person

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 2739d32a-b189-4f7c-b118-ce3361be611d
📥 Commits

Reviewing files that changed from the base of the PR and between cc83a73 and dd8d3c9.

📒 Files selected for processing (1)
  • public/app.js

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The recipient-row mousedown handler now lets clicks on the input follow normal focus behavior and reopen suggestions when the input is already focused. Clicks elsewhere in the row still focus the input and move the caret to the end. Clicks on removal controls, options, and the menu remain excluded.

Suggested reviewers: aimemp

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to dd8d3

The described change reopens recipient suggestions on repeat input clicks while preserving normal input behavior and excluding removal and menu interactions. No concrete merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: reopening the recipient list when the To or Cc field is clicked again.
Description check ✅ Passed The description explains the recipient-list behavior change and includes relevant changes and test steps.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@BrianGenisio
BrianGenisio merged commit 4c6442c into main Oct 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant